Bug 442563

Summary: Display Configuration KCM is empty while dialog to confirm changes is visible
Product: [Applications] systemsettings Reporter: Patrick Silva <bugseforuns>
Component: kcm_kscreenAssignee: kscreen-bugs-null <kscreen-bugs-null>
Status: RESOLVED FIXED    
Severity: minor CC: nate, plasma-bugs-null, rizzitello
Priority: NOR    
Version First Reported In: 5.22.90   
Target Milestone: ---   
Platform: Arch Linux   
OS: Linux   
Latest Commit: https://invent.kde.org/plasma/kscreen/commit/1dce74ff4719930a9e53326f29aab117b61ed0a7 Version Fixed/Implemented In: 5.23
Sentry Crash Report:
Attachments: screenshot

Description Patrick Silva 2021-09-16 21:58:58 UTC 
STEPS TO REPRODUCE
1. open Display Configuration KCM
2. change display scale or RGB range setting
3. click on Apply button

OBSERVED RESULT
dialog to confirm or revert the change shows up and the KCM is empty behind it.
Please see the attached screenshot.

EXPECTED RESULT
unchanged KCM behind the dialog

SOFTWARE/OS VERSIONS
Operating System: Arch Linux
KDE Plasma Version: 5.22.90
KDE Frameworks Version: 5.86.0
Qt Version: 5.15.2
Graphics Platform: Wayland
Comment 1 Patrick Silva 2021-09-16 21:59:55 UTC 
Created attachment 141631 [details]
screenshot
Comment 2 Nate Graham 2021-09-18 04:56:23 UTC 
True. Not sure it's a huge deal though.
Comment 3 Chris Rizzitello 2021-09-18 12:25:29 UTC 
This Happens because the Kirigami overlays parent is "root.parent". Its trivial to "fix" we just set the overlays parent to "root". However I choose to use root.parent to be inline with the other kcm overlays and to discourage people from clicking on content in the kcm and not on the dialog while it is shown.
Comment 4 Nate Graham 2021-09-20 17:15:43 UTC 
It doesn't matter if they try to click on content in the view below becauseit will simply close the dialog, right? I think it might be good to align with what other apps do here rather than using a custom behavior.
Comment 5 Bug Janitor Service 2021-09-20 17:21:10 UTC 
A possibly relevant merge request was started @ https://invent.kde.org/plasma/kscreen/-/merge_requests/43
Comment 6 Nate Graham 2021-09-20 19:19:07 UTC 
Git commit 7ca8821b6b704dd99168292994cf0069d42fa37c by Nate Graham.
Committed on 20/09/2021 at 17:17.
Pushed by ngraham into branch 'master'.

kcm: Use more conventional parent/background for OverlaySheet

Parenting to the KCM itself rather than its parent prevents the view
from disappearing while the OverlaySheet is open, which looks a but odd
and generated a bug report. Let's set the parent to the KCM so that the
rest of the UI beneath the dialog remains visible, as we see in other
software that uses the Kirigami.OverlaySheet component.
FIXED-IN: 5.23

M  +1    -1    kcm/package/contents/ui/main.qml

https://invent.kde.org/plasma/kscreen/commit/7ca8821b6b704dd99168292994cf0069d42fa37c
Comment 7 Nate Graham 2021-09-20 19:29:05 UTC 
Git commit 1dce74ff4719930a9e53326f29aab117b61ed0a7 by Nate Graham.
Committed on 20/09/2021 at 19:29.
Pushed by ngraham into branch 'Plasma/5.23'.

kcm: Use more conventional parent/background for OverlaySheet

Parenting to the KCM itself rather than its parent prevents the view
from disappearing while the OverlaySheet is open, which looks a but odd
and generated a bug report. Let's set the parent to the KCM so that the
rest of the UI beneath the dialog remains visible, as we see in other
software that uses the Kirigami.OverlaySheet component.
FIXED-IN: 5.23


(cherry picked from commit 7ca8821b6b704dd99168292994cf0069d42fa37c)

M  +1    -1    kcm/package/contents/ui/main.qml

https://invent.kde.org/plasma/kscreen/commit/1dce74ff4719930a9e53326f29aab117b61ed0a7
Comment 8 Nate Graham 2021-09-21 21:33:02 UTC 
*** Bug 442672 has been marked as a duplicate of this bug. ***