| Summary: | Breeze Light color scheme: Selection Active Text is blue when it should be white | ||
|---|---|---|---|
| Product: | [Plasma] Breeze | Reporter: | Oleg Solovyov <mcpain> |
| Component: | Color scheme | Assignee: | Plasma Bugs List <plasma-bugs> |
| Status: | RESOLVED FIXED | ||
| Severity: | normal | CC: | nate |
| Priority: | NOR | ||
| Version: | 5.22.4 | ||
| Target Milestone: | --- | ||
| Platform: | Other | ||
| OS: | Linux | ||
| Latest Commit: | https://invent.kde.org/plasma/breeze/commit/2051d29ba7232726c4e795d940dc1edde1a98ba1 | Version Fixed In: | 5.23 |
| Sentry Crash Report: | |||
| Attachments: |
invisible text
Breeze theme |
||
The colors are correct in the color scheme; this is an app bug where it inappropriately hardcodes some colors. Created attachment 141639 [details] Breeze theme (In reply to Nate Graham from comment #1) > The colors are correct in the color scheme; this is an app bug where it > inappropriately hardcodes some colors. I don't think so. Same app, same versions, different color scheme (Breeze vs. Breeze Light) Hmm yeah looks like Selection Active Text is wrong in Breeze Light. It's currently blue when it should be white. However in general the code in question is crying out for using Kirigami.BasicListItem instead, which would probably save hundreds of lines of code and fix bugs like this. Git commit 09a0b5199c9653a4aa357506b8cb5aac7999f369 by Nate Graham. Committed on 17/09/2021 at 19:53. Pushed by ngraham into branch 'master'. Fix incorrect active selection color in Breeze Light color scheme Looks like an oversight at some point in the last, as all three other Breeze* color schemes have the correct value here. FIXED-IN: 5.23 M +1 -1 colors/BreezeLight.colors https://invent.kde.org/plasma/breeze/commit/09a0b5199c9653a4aa357506b8cb5aac7999f369 Git commit 2051d29ba7232726c4e795d940dc1edde1a98ba1 by Nate Graham. Committed on 17/09/2021 at 19:55. Pushed by ngraham into branch 'Plasma/5.23'. Fix incorrect active selection color in Breeze Light color scheme Looks like an oversight at some point in the last, as all three other Breeze* color schemes have the correct value here. FIXED-IN: 5.23 (cherry picked from commit 09a0b5199c9653a4aa357506b8cb5aac7999f369) M +1 -1 colors/BreezeLight.colors https://invent.kde.org/plasma/breeze/commit/2051d29ba7232726c4e795d940dc1edde1a98ba1 Note that because of the way colors are serialized to the ~./config/kdeglobals file, you will need to switch you color scheme to something else and then back to Breeze light to pick up the change. We ultimately want to make that not be required; see https://phabricator.kde.org/T13663. |
Created attachment 141561 [details] invisible text SUMMARY Using Breeze Light color theme, some texts become invisible. e.g. profile list in ktouch. Selected profile is unreadable because text and background colors are equal SOFTWARE/OS VERSIONS Linux/KDE Plasma: 5.11.0 KDE Plasma Version: 5.22.5 KDE Frameworks Version: 5.86.0 Qt Version: 5.15.3