Bug 442460

Summary: Help button doesn't work, just stays highlighted and doesn't pop up the Help Centre
Product: [Applications] systemsettings Reporter: strangequark <random1123581321>
Component: kcm_kwinscriptsAssignee: KWin default assignee <kwin-bugs-null>
Status: RESOLVED FIXED    
Severity: normal CC: nate, plasma-bugs-null
Priority: NOR    
Version First Reported In: 5.22.5   
Target Milestone: ---   
Platform: Neon   
OS: Linux   
Latest Commit: https://invent.kde.org/plasma/kwin/commit/8bea1d1315f8360712c1fb496b3d958af6f86461 Version Fixed/Implemented In: 5.23
Sentry Crash Report:

Description strangequark 2021-09-15 06:20:29 UTC 
SUMMARY
The help button in some System Settings pages doesn't work. It just stays highlighted in the light blue color and doesn't actually open the Help Centre.  

STEPS TO REPRODUCE
1. Open System Settings
2. Go to Window Management -> KWin Scripts
3. Click the Help button

OBSERVED RESULT
Nothing happens.

EXPECTED RESULT
Help Centre should open to the page on KWin Scripts (which I believe doesn't exist; I couldn't find it)

SOFTWARE/OS VERSIONS
Operating System: KDE neon 5.22
KDE Plasma Version: 5.22.5
KDE Frameworks Version: 5.85.0
Qt Version: 5.15.3
Kernel Version: 5.11.0-34-generic (64-bit)
Graphics Platform: X11

ADDITIONAL INFORMATION
none
Comment 1 Nate Graham 2021-09-16 17:43:34 UTC 
Indeed, it doesn't do anything. :/

We should simply not show a help button if there is no help.
Comment 2 Bug Janitor Service 2021-09-17 23:17:19 UTC 
A possibly relevant merge request was started @ https://invent.kde.org/plasma/kwin/-/merge_requests/1432
Comment 3 Nate Graham 2021-09-20 19:54:13 UTC 
Git commit 095f953847e6cebd10e06a2a431bd025037f7909 by Nate Graham.
Committed on 20/09/2021 at 19:52.
Pushed by ngraham into branch 'master'.

kcmkwin/kwinscripts: Hide help button

There is no help for this KCM, so don't show the Help button.
FIXED-IN: 5.23

M  +3    -0    src/kcmkwin/kwinscripts/module.cpp

https://invent.kde.org/plasma/kwin/commit/095f953847e6cebd10e06a2a431bd025037f7909
Comment 4 Nate Graham 2021-09-20 19:54:59 UTC 
Git commit 8bea1d1315f8360712c1fb496b3d958af6f86461 by Nate Graham.
Committed on 20/09/2021 at 19:54.
Pushed by ngraham into branch 'Plasma/5.23'.

kcmkwin/kwinscripts: Hide help button

There is no help for this KCM, so don't show the Help button.
FIXED-IN: 5.23


(cherry picked from commit 095f953847e6cebd10e06a2a431bd025037f7909)

M  +3    -0    src/kcmkwin/kwinscripts/module.cpp

https://invent.kde.org/plasma/kwin/commit/8bea1d1315f8360712c1fb496b3d958af6f86461