Bug 442353

Summary: Brushes seemingly randomly fail to properly load their pattern
Product: [Applications] krita Reporter: tomtomtomreportingin
Component: Resource ManagementAssignee: Halla Rempt <halla>
Status: RESOLVED FIXED    
Severity: normal CC: anno2300, dimula73, halla, raghu, razcore.rad, uenvironments
Priority: NOR Keywords: regression
Version First Reported In: nightly build (please specify the git hash!)   
Target Milestone: ---   
Platform: Appimage   
OS: Linux   
Latest Commit: Version Fixed/Implemented In:
Sentry Crash Report:

Description tomtomtomreportingin 2021-09-12 20:39:41 UTC 
(5.0.0-beta1 git 7f1fe37 and 5.1.0-prealpha git 1c72b2c)

SUMMARY
Certain brushes like brushes from the Mojo bundles can lose their original pattern after configuring any setting through the brush editor. Reloading the preset brings the pattern back.

See the bottom of the report for regression information.

STEPS TO REPRODUCE
1. Download Mojo Moo Ink from https://saeger.art/mojo-moo/bundles by clicking the Bundle button. Install the bundle.
2. Under the moo ink tag, select moo-zip-cute-06 (first brush).
3. Draw. Observe pattern.
4. Open brush editor and increase diameter by a step. (do not use toolbar sliders)
5. Draw. Observe pattern.

OBSERVED RESULT
Stroke is completely filled.

EXPECTED RESULT
Stroke should be patterned.

SOFTWARE/OS VERSIONS
Linux/KDE Plasma: Debian sid
KDE Plasma Version: 5.21.5
KDE Frameworks Version: 5.85.0
Qt Version: 5.12.11 (Appimage)

The particular brush noted in the reproduction steps does not have this problem in the released beta 1, however the other zip cute brushes were outright broken regardless of configuration. As of recent fixes included in the versions noted at the top, these brushes only break on configuration, with the noted brush now also having this problem. Using the toolbar sliders doesn't break them.
Comment 1 tomtomtomreportingin 2021-09-12 21:01:20 UTC 
Some brushes such as moo-zip-cute-78 also have buggy patterned strokes that don't occur in 4.4.7, however this may be a separate issue.
Comment 2 tomtomtomreportingin 2021-09-12 21:23:45 UTC 
I've determined that downloading the bundle isn't necessary: This happens with even default brushes such as Dry Bristles randomly failing to properly load their patterns on strokes (especially on line/shape tool strokes), and I've observed one of my own custom brushes having this problem without any configuration from its default settings.
Comment 3 Halla Rempt 2021-09-13 08:11:16 UTC 
*** Bug 442373 has been marked as a duplicate of this bug. ***
Comment 4 wolthera 2021-09-21 15:57:58 UTC 
*** Bug 441702 has been marked as a duplicate of this bug. ***
Comment 5 Halla Rempt 2021-09-30 08:12:48 UTC 
*** Bug 443138 has been marked as a duplicate of this bug. ***
Comment 6 Dmitry Kazakov 2021-10-06 10:23:33 UTC 
This bug should be fixed with 

https://invent.kde.org/graphics/krita/-/merge_requests/1081
Comment 7 Dmitry Kazakov 2021-10-06 12:39:47 UTC 
The fix is merged now!