Bug 442286

Summary: Text in new "Shift to extend tooltip" is broken with Breeze High Contrast
Product: [Plasma] Breeze Reporter: Thiago Sueto <herzenschein>
Component: Color schemeAssignee: Plasma Bugs List <plasma-bugs>
Status: RESOLVED FIXED    
Severity: normal CC: nate
Priority: NOR Keywords: accessibility
Version: unspecified   
Target Milestone: ---   
Platform: Other   
OS: Linux   
See Also: https://bugs.kde.org/show_bug.cgi?id=352506
Latest Commit: Version Fixed In: 5.24
Sentry Crash Report:
Attachments: Broken text with Breeze High Contrast

Description Thiago Sueto 2021-09-11 00:01:14 UTC
Created attachment 141462 [details]
Broken text with Breeze High Contrast

Really, the screenshot should be self-explanatory.

Text mentioning "Press shift to see more" is gray and unreadable in tooltips.
Comment 1 Nate Graham 2021-09-16 19:08:16 UTC
Hmm yeah. Based on the code, it looks like the is an issue with the color scheme's inactive text color or its tooltip color.

From kxmlgui/src/ktooltiphelper.cpp:
const QColor hintTextColor = colorScheme.foreground(KColorScheme::InactiveText).color();
Comment 2 Nate Graham 2021-09-17 20:40:00 UTC
Problem with the inactive tooltip color given the blue background.
Comment 3 Bug Janitor Service 2021-09-17 21:48:42 UTC
A possibly relevant merge request was started @ https://invent.kde.org/plasma/breeze/-/merge_requests/141
Comment 4 Nate Graham 2021-09-21 16:35:29 UTC
Git commit bb70d9c5a61d18800480f1c5be6c6e0bd240b796 by Nate Graham.
Committed on 21/09/2021 at 16:17.
Pushed by ngraham into branch 'master'.

Delete high contrast color scheme

This color scheme is a misnomer, and does not actually offer higher
contrast than other color schemes. In fact its contrast is generally
worse. As a result it hurts more than it helps. A true "high contrast
mode" would require changes to the QStyle to make UI elements larger or
change their borders to actually offer an improvement for people who
need higher contrast than what is offered by Breeze and Breeze Dark.

Accordingly, let's delete this color scheme and migrate current users to
Breeze Dark, which is the shipped theme that looks closest to it, and
has *better* contrast in many ways.
Related: bug 352506
FIXED-IN: 5.24

D  +0    -158  colors/BreezeHighContrast.colors
M  +0    -2    colors/CMakeLists.txt
M  +1    -0    misc/CMakeLists.txt
A  +8    -0    misc/breezehighcontrasttobreezedark/CMakeLists.txt
A  +3    -0    misc/breezehighcontrasttobreezedark/breezehighcontrasttobreezedark.upd
A  +23   -0    misc/breezehighcontrasttobreezedark/main.cpp  *

The files marked with a * at the end have a non valid license. Please read: https://community.kde.org/Policies/Licensing_Policy and use the headers which are listed at that page.


https://invent.kde.org/plasma/breeze/commit/bb70d9c5a61d18800480f1c5be6c6e0bd240b796