Bug 442252

Summary:	konsole starts with tiny window if old konsolerc present
Product:	[Applications] konsole	Reporter:	Fabian Vogt <fabian>
Component:	general	Assignee:	Konsole Developer <konsole-devel>
Status:	RESOLVED FIXED
Severity:	normal	CC:	a.samirh78, kdelibs-bugs, piotr.mierzwinski, trilader+kdebugs
Priority:	NOR
Version:	21.08.1
Target Milestone:	---
Platform:	openSUSE
OS:	Linux
Latest Commit:	https://invent.kde.org/utilities/konsole/commit/3177c9ef8a21bacd52a11e797675e0488bad9e15	Version Fixed In:	21.12
Sentry Crash Report:

Description Fabian Vogt 2021-09-10 09:02:48 UTC

When starting konsole 21.08 with a konsolerc from 17.04.2 with kxmlgui 5.32.0 (from Leap 42.3) like this:

[Desktop Entry]
DefaultProfile=

[Favorite Profiles]
Favorites=

[MainWindow]
State=AAAA/wAAAAD9AAAAAAAABAAAAAKhAAAABAAAAAQAAAAIAAAACPwAAAAA
ToolBarsMovable=Disabled
Window-Maximized 768x1024=true

it shows up as a 0x0 window like reported in https://bugs.kde.org/show_bug.cgi?id=437791.

FWICT, the included State is pretty much empty and results in the 0x0 size.

Old konsole + old kxmlgui save the broken state reproducibly, it was just never noticed back then because some fallback in either konsole or kxmlgui set a usable size on startup. This is no longer the case, and the restored 0x0 size is used as-is.

I don't know whether this should be handled by konsole, kxmlgui or both.

Downstream report: https://bugzilla.opensuse.org/show_bug.cgi?id=1189927

Comment 1 Ahmad Samir 2021-09-10 22:25:08 UTC

*** Bug 442284 has been marked as a duplicate of this bug. ***

Comment 2 Ahmad Samir 2021-09-10 22:51:48 UTC

It looks like it's not just the State= key, these ones come into play too:
DP-1 Height
DP-1 Width
DP-1 XPosition
DP-1 YPosition

Comment 3 Ahmad Samir 2021-09-10 22:56:29 UTC

(It's also possible I got it wrong and State has nothing to do with the window size).

Comment 4 Bug Janitor Service 2021-09-11 15:32:46 UTC

A possibly relevant merge request was started @ https://invent.kde.org/utilities/konsole/-/merge_requests/483

Comment 5 Ahmad Samir 2021-09-15 20:46:57 UTC

*** Bug 442492 has been marked as a duplicate of this bug. ***

Comment 6 Kurt Hindenburg 2021-09-17 16:41:29 UTC

Git commit 3177c9ef8a21bacd52a11e797675e0488bad9e15 by Kurt Hindenburg, on behalf of Ahmad Samir.
Committed on 15/09/2021 at 20:26.
Pushed by hindenburg into branch 'master'.

Always save the window state and geometry

This includes the toolbar/menubar/dockwidget states (i.e. the State= config
key), and the window geometry. I was wrong to think the State= key included
the window geometry.

Depending on the "remeber window size" setting, we can apply the size saved
in the config file or the size from the profile settings (lines x columns),
which is included in MainWindow::sizeHint().
FIXED-IN: 21.12

M  +25   -38   src/MainWindow.cpp
M  +6    -1    src/MainWindow.h

https://invent.kde.org/utilities/konsole/commit/3177c9ef8a21bacd52a11e797675e0488bad9e15