Bug 442171

Summary: The default Fuzziness value is way too high in Fill tool and Contiguous Selection tool
Product: [Applications] krita Reporter: Tyson Tan <tysontanx>
Component: ToolsAssignee: tomtomtomreportingin
Status: RESOLVED FIXED    
Severity: normal CC: tomtomtomreportingin
Priority: NOR    
Version First Reported In: 5.0.0-beta1   
Target Milestone: ---   
Platform: Other   
OS: Linux   
Latest Commit: https://invent.kde.org/graphics/krita/commit/50c3d4109b9f4a4212d4ee28da017ac9c7f2844e Version Fixed/Implemented In:
Sentry Crash Report:

Description Tyson Tan 2021-09-08 12:33:01 UTC 
Krita's Fill tool has a default Fuziness value of 80. The Contiguous Selection tool has 20. They are way too high. You can't select with that number, because it'll select EVERYTHING! 

This is a very common complain from new users, who often think Krita is broken because of that. 

By "80", did you really mean to "8"? Because Photoshop uses 8, and it was a pretty nice middle ground when I was using it.
Comment 1 tomtomtomreportingin 2021-09-08 16:33:44 UTC 
Yea, I think a value of 8 makes sense from some testing.
Comment 2 tomtomtomreportingin 2021-09-08 17:04:35 UTC 
To clarify, do you think 8 would also be fine for contig selection fuzziness? Or should it be something like 10 or 16?
Comment 3 Tyson Tan 2021-09-08 17:35:40 UTC 
I think 8 works best in both tools.

Contiguous Selection with 16 Fuziness still selects too much colors that are obviously different.

I think people expect Fill tool and Contiguous Select to work the same.

Under the hood, they are the same in Krita, after all.
Comment 4 Bug Janitor Service 2021-09-08 17:53:17 UTC 
A possibly relevant merge request was started @ https://invent.kde.org/graphics/krita/-/merge_requests/1044
Comment 5 Halla Rempt 2021-09-09 09:41:35 UTC 
Git commit ea017d4e55923fd6dde64a2bd885327729e7670e by Halla Rempt, on behalf of Tom Tom Tom.
Committed on 09/09/2021 at 09:41.
Pushed by rempt into branch 'master'.

Tweak default threshold/fuzziness values

M  +1    -1    plugins/tools/basictools/kis_tool_fill.cc
M  +1    -1    plugins/tools/selectiontools/kis_tool_select_contiguous.cc

https://invent.kde.org/graphics/krita/commit/ea017d4e55923fd6dde64a2bd885327729e7670e
Comment 6 Tyson Tan 2021-09-09 11:57:55 UTC 
Thank you Tom and Halla! :D
Comment 7 Halla Rempt 2021-09-09 13:22:33 UTC 
Git commit 50c3d4109b9f4a4212d4ee28da017ac9c7f2844e by Halla Rempt, on behalf of Tom Tom Tom.
Committed on 09/09/2021 at 13:21.
Pushed by rempt into branch 'krita/5.0'.

Tweak default threshold/fuzziness values
(cherry picked from commit ea017d4e55923fd6dde64a2bd885327729e7670e)

M  +1    -1    plugins/tools/basictools/kis_tool_fill.cc
M  +1    -1    plugins/tools/selectiontools/kis_tool_select_contiguous.cc

https://invent.kde.org/graphics/krita/commit/50c3d4109b9f4a4212d4ee28da017ac9c7f2844e