Bug 442155

Summary:	Animation Timeline Docker's Layer toggle icons have no i18n for (on) (off) in their tooltips
Product:	[Applications] krita	Reporter:	Tyson Tan <tysontanx>
Component:	Translation	Assignee:	Emmet O'Neill <emmetoneill.pdx>
Status:	RESOLVED FIXED
Severity:	normal	CC:	eoinoneill1991, halla
Priority:	NOR
Version First Reported In:	5.0.0-beta1
Target Milestone:	---
Platform:	Other
OS:	Linux
Latest Commit:		Version Fixed/Implemented In:
Sentry Crash Report:

Description Tyson Tan 2021-09-08 03:40:13 UTC

In Krita's Animation Timeline Docker there is a Layer panel, which has a few toggle icons for Visibility, Lock, Inherit Alpha, Alpha lock and Onion Skins.

When the cursor is over these icons, a tooltip pops up to show their functionalities and states. But the strings for (on) and (off) are untranslatable.

I can handle the i18n myself, but I'm unable to find where they are in Krita's code. Help will be greatly appreciated.

Comment 1 Halla Rempt 2021-09-08 09:06:35 UTC

Can you take a look? Maybe check the animations ui for other places where i18n was forgotten?

Comment 2 Tyson Tan 2021-09-09 12:30:54 UTC

The Filter list in wdg_animationrenderer.ui：206 one has not been internationalized. (The items like Bicubic, Bilinear and stuff).

Comment 3 Emmet O'Neill 2021-09-15 02:48:33 UTC

Ok, the missing i18n wrappers have been added in both timeline_node_list_keeper.cpp and KisDlgAnimationRenderer.cpp.

(I also gave some of the surrounding code a glance to see if any other missing i18n jumped out at me and I couldn't find any--though it can be a bit hard in the renderer as there's a lot of FFMpeg string funny business happening. Please let me know if I missed something.)

Comment 4 Emmet O'Neill 2021-09-15 02:49:13 UTC

Also thanks for the report and all your hard work, Tyson. :)

Comment 5 Tyson Tan 2021-09-15 03:49:04 UTC

Thank you and you're welcome Emmet! :)