| Summary: | Do not disable next/previous track buttons when current track is being paused | ||
|---|---|---|---|
| Product: | [Applications] Elisa | Reporter: | Nagy Tibor <xnagytibor> |
| Component: | general | Assignee: | Matthieu Gallien <matthieu_gallien> |
| Status: | RESOLVED FIXED | ||
| Severity: | normal | CC: | nate |
| Priority: | NOR | Keywords: | usability |
| Version: | 21.08.1 | ||
| Target Milestone: | --- | ||
| Platform: | Neon | ||
| OS: | Linux | ||
| Latest Commit: | https://invent.kde.org/multimedia/elisa/commit/62d3fd14db7bce19cc738ef9393008ea3b753457 | Version Fixed In: | 21.08.2 |
| Attachments: | Repro | ||
Yeah, that's weird. Why *do* we do that, anyway? Notably, the in-app and global Next and Previous shortcuts still work, so this seems like just a bug. I'll fix it. ElisaApplication.playerControl.skipForwardControlEnabled and ElisaApplication.playerControl.skipBackwardControlEnabled seem to be getting set to false inappropriately, but they aren't even blocking the shortcuts anyway... :/ A possibly relevant merge request was started @ https://invent.kde.org/multimedia/elisa/-/merge_requests/289 Git commit 62d3fd14db7bce19cc738ef9393008ea3b753457 by Nate Graham. Committed on 16/09/2021 at 20:02. Pushed by ngraham into branch 'release/21.08'. Don't unnecessarily disable back and forward buttons when paused You might still want to move backwards or forward when the player is paused. FIXED-IN: 21.08.2 M +7 -7 autotests/managemediaplayercontroltest.cpp M +2 -2 src/managemediaplayercontrol.cpp https://invent.kde.org/multimedia/elisa/commit/62d3fd14db7bce19cc738ef9393008ea3b753457 |
Created attachment 141367 [details] Repro SUMMARY Currently when a track is being paused, Elisa always disables the next and previous track buttons. This behavior is kinda counterproductive, I haven't seen any media players other than Elisa doing this. Just because the current track is paused it doesn't mean that jumping backwards/forwards on the current playlist becomes an invalid action to do. Elisa should only disable these buttons when it's at the start/end of the current playlist. SOFTWARE/OS VERSIONS Operating System: KDE neon 5.22 KDE Plasma Version: 5.22.5 KDE Frameworks Version: 5.85.0 Qt Version: 5.15.3