Summary: | Krita crashes if SeExpr scripts are saved without a thumbnail | ||
---|---|---|---|
Product: | [Applications] krita | Reporter: | amyspark <amy> |
Component: | Resource Management | Assignee: | amyspark <amy> |
Status: | RESOLVED FIXED | ||
Severity: | crash | CC: | halla |
Priority: | NOR | ||
Version: | git master (please specify the git hash!) | ||
Target Milestone: | --- | ||
Platform: | Microsoft Windows | ||
OS: | Microsoft Windows | ||
URL: | https://krita-artists.org/t/krita-crashes-while-saving-seexpr-script-with-empty-thumbnail/28511 | ||
Latest Commit: | https://invent.kde.org/graphics/krita/commit/082e2deee1db3fe368205e0384bba9059189f795 | Version Fixed In: |
Description
amyspark
2021-09-06 22:52:29 UTC
This should fix it... diff --git a/plugins/generators/seexpr/kis_wdg_seexpr_presets_save.cpp b/plugins/generators/seexpr/kis_wdg_seexpr_presets_save.cpp index b633279edd..6845cb907b 100644 --- a/plugins/generators/seexpr/kis_wdg_seexpr_presets_save.cpp +++ b/plugins/generators/seexpr/kis_wdg_seexpr_presets_save.cpp @@ -151,7 +151,9 @@ void KisWdgSeExprPresetsSave::savePreset() } newPreset->setFilename(presetFileName); newPreset->setName(presetName); - newPreset->setImage(presetThumbnailWidget->pixmap()->toImage()); + if (presetThumbnailWidget->pixmap()) { + newPreset->setImage(presetThumbnailWidget->pixmap()->toImage()); + } newPreset->setScript(m_currentConfiguration->getString("script")); newPreset->setDirty(false); newPreset->setValid(true); A possibly relevant merge request was started @ https://invent.kde.org/graphics/krita/-/merge_requests/1040 Git commit 0636d6f1f1744a05b67deca647b56bb5bd790a4e by Halla Rempt, on behalf of L. E. Segovia. Committed on 08/09/2021 at 07:47. Pushed by rempt into branch 'master'. Make SeExpr script thumbnails optional Co-authored-by: Halla Rempt <halla@valdyas.org> M +4 -2 plugins/generators/seexpr/kis_wdg_seexpr_presets_save.cpp https://invent.kde.org/graphics/krita/commit/0636d6f1f1744a05b67deca647b56bb5bd790a4e Git commit 082e2deee1db3fe368205e0384bba9059189f795 by L. E. Segovia. Committed on 14/09/2021 at 14:45. Pushed by lsegovia into branch 'krita/5.0'. Make SeExpr script thumbnails optional Co-authored-by: Halla Rempt <halla@valdyas.org> (cherry picked from commit 0636d6f1f1744a05b67deca647b56bb5bd790a4e) M +4 -2 plugins/generators/seexpr/kis_wdg_seexpr_presets_save.cpp https://invent.kde.org/graphics/krita/commit/082e2deee1db3fe368205e0384bba9059189f795 |