| Summary: | OverviewWidget::generateThumbnail starts stroke repeatedly when idle | ||
|---|---|---|---|
| Product: | [Applications] krita | Reporter: | Alvin Wong <alvin> |
| Component: | Dockers | Assignee: | Krita Bugs <krita-bugs-null> |
| Status: | RESOLVED FIXED | ||
| Severity: | normal | CC: | dimula73 |
| Priority: | NOR | ||
| Version: | git master (please specify the git hash!) | ||
| Target Milestone: | --- | ||
| Platform: | unspecified | ||
| OS: | Unspecified | ||
| Latest Commit: | https://invent.kde.org/graphics/krita/commit/70849865578ec500378abef9eac9decb46c131d3 | Version Fixed In: | |
| Sentry Crash Report: | |||
| Attachments: | backtrace of OverviewWidget stroke spawning thread | ||
Git commit f16f95f9eb09ef4e4fcca33ae3eebf5a9c452c99 by Alvin Wong. Committed on 07/09/2021 at 07:44. Pushed by alvinwong into branch 'master'. Fix duplicated signal/slot connection in OverviewWidget This was causing `OverviewWidget::generateThumbnail` to be triggered every second when more than one document has been opened during one session. M +1 -1 plugins/dockers/overview/overviewwidget.cc https://invent.kde.org/graphics/krita/commit/f16f95f9eb09ef4e4fcca33ae3eebf5a9c452c99 Git commit 70849865578ec500378abef9eac9decb46c131d3 by Alvin Wong. Committed on 07/09/2021 at 07:46. Pushed by alvinwong into branch 'krita/5.0'. Fix duplicated signal/slot connection in OverviewWidget This was causing `OverviewWidget::generateThumbnail` to be triggered every second when more than one document has been opened during one session. (cherry picked from commit f16f95f9eb09ef4e4fcca33ae3eebf5a9c452c99) M +1 -1 plugins/dockers/overview/overviewwidget.cc https://invent.kde.org/graphics/krita/commit/70849865578ec500378abef9eac9decb46c131d3 |
Created attachment 141333 [details] backtrace of OverviewWidget stroke spawning thread For unknown reasons, OverviewWidget::generateThumbnail will repeatedly start a stroke to generate the thumbnail, which triggers thread spawns about every one second due to existing inefficiency with the thread pool implementation. It seems to happen after creating/opening a file, closing it and then creating another file. (Note that this report is not about fixing the thread pool implementation.) I have observed this behaviour with commit e7580089 on Linux docker build and 6ca8117 on Windows nightly build.