Summary: | chord definitions for dominant seventh chords are mostly wrong | ||
---|---|---|---|
Product: | [Applications] minuet | Reporter: | dexxter |
Component: | general | Assignee: | Tammes Burghard <kde> |
Status: | RESOLVED FIXED | ||
Severity: | critical | CC: | kde |
Priority: | NOR | ||
Version: | unspecified | ||
Target Milestone: | --- | ||
Platform: | Ubuntu | ||
OS: | Linux | ||
Latest Commit: | Version Fixed In: |
Description
dexxter
2021-09-04 11:47:18 UTC
Yes, that should work. If you want to do that just for yourself, you would have to find that file. I didn't find it yet, but will try to. However, adding definitions upstream also is an option. I will try to fix this mistake there. Hmmm. I just looked through the definitions and they look correct to me. I will close this, if you disagree feel free to reopen and explain in further detail. for example: { "tags": ["chord", "root-position", "major", "9", "extended"], "name": "Major 9", "sequence": "4 7 10 14" }, shouldn't say "Major 9" but "Dominant 9", because the seventh is a minor seventh. A Xmaj9 chord is a major chord with a major seventh with a major ninth added, a X9 chord is a major chord with a minor seventh and major ninth added. In the example the seventh has 10 semitones which makes it a dominant chord. I think the name of the chord is in all cases misleading. All "Major" and "Minor" names should disappear in favour of the correct chord symbol. the chord symbol should say X^9 because then its clear you want a dominant seventh chord with a major ninth. A X^maj9 chord would contain a major seventh and a major ninth Ah, you are talking about the bigger chords. I only checked the seventh ones. Yes I agree that symbols would be better. I don't yet know how to render them correctly, but will think about it. I looked into it a bit more and now think the chords that have a proper name should be called by that name. I will work on it and probably make a MR in the next days. I made a [branch](https://invent.kde.org/kuchenmampfer/minuet/-/tree/overhaul_exercises?ref_type=heads) already containing a chord rework that should fix this. However, I decided that while I am at it, I might as well overhaul all the definitions and exercises. So the MR will have to wait until that is done. (In reply to Tammes Burghard from comment #6) > I made a > [branch](https://invent.kde.org/kuchenmampfer/minuet/-/tree/ > overhaul_exercises?ref_type=heads) already containing a chord rework that > should fix this. However, I decided that while I am at it, I might as well > overhaul all the definitions and exercises. So the MR will have to wait > until that is done. That looks very good! Thanks |