| Summary: | Closing a project with no VCS crashes KDevelop | ||
|---|---|---|---|
| Product: | [Applications] kdevelop | Reporter: | Igor Kushnir <igorkuo> |
| Component: | VCS: Git | Assignee: | kdevelop-bugs-null |
| Status: | RESOLVED FIXED | ||
| Severity: | crash | CC: | jpmbatrina01 |
| Priority: | NOR | Keywords: | drkonqi |
| Version First Reported In: | git master | ||
| Target Milestone: | --- | ||
| Platform: | Compiled Sources | ||
| OS: | Linux | ||
| Latest Commit: | https://invent.kde.org/kdevelop/kdevelop/commit/d4f79c14e61c15e0b47b476423217f4c7b4414dc | Version Fixed In: | |
| Sentry Crash Report: | |||
|
Description
Igor Kushnir
2021-09-02 07:04:12 UTC
> The reporter is unsure if this crash is reproducible.
That's my reporting mistake. Actually the crash can be reproduced every time on every project without a VCS.
In a Debug build the assertion is triggered: ASSERT: "proj" in file /home/Fast_storage/kdevelop/plugins/git/repostatusmodel.cpp, line 158
Can confirm with kdevelop built from master. Possibly related to https://bugs.kde.org/show_bug.cgi?id=441807 since both crashes are in QStandardItem::rowCount() and are VCS-related. Can you test if the crash does not occur before the commit 6e999b0161a2610b0a256316481b39d5b1d3b9f0? A possibly relevant merge request was started @ https://invent.kde.org/kdevelop/kdevelop/-/merge_requests/252 A possibly relevant merge request was started @ https://invent.kde.org/kdevelop/kdevelop/-/merge_requests/252 > Can you test if the crash does not occur before the commit 6e999b0161a2610b0a256316481b39d5b1d3b9f0?
Makes more sense for you to test if the SVN crash is fixed by my merge request :)
> Makes more sense for you to test if the SVN crash is fixed by my merge request :)
Jan Paul Batrina, sorry, mixed you up with the svn crash reporter :)
I'll ask the reporter of the svn crash to test the patch.
It's all right, I would have tested it too but sadly I'm not too familiar with subversion. Glad you quickly found a fix! Hopefully both bugs are fixed after that is merged Git commit d4f79c14e61c15e0b47b476423217f4c7b4414dc by Igor Kushnir.
Committed on 03/09/2021 at 17:42.
Pushed by igorkushnir into branch 'master'.
Git Support plugin: don't crash on projects with another or no VCS
This fix eliminates two crashes:
* when a project w/o VCS is closed;
* when a file in a subversion project is saved.
Related: bug 441807
M +3 -1 plugins/git/repostatusmodel.cpp
M +1 -1 plugins/git/repostatusmodel.h
https://invent.kde.org/kdevelop/kdevelop/commit/d4f79c14e61c15e0b47b476423217f4c7b4414dc
|