Bug 441889

SUMMARY

The new SSH Manager plugin does not accept port numbers above 9999. This is a bit of a problem for my own use case, where I have access to systems with ssh servers listening on port numbers well above 10000.


STEPS TO REPRODUCE

1. Use Plugins -> Show SSH Manager
2. Click on Add to add a new SSH configuration
3. Attempt to enter 12345 into the Port field

OBSERVED RESULT

The maximum port number that may be entered is 9999.

EXPECTED RESULT

The maximum port number that may be entered should be a larger number above 9999 and below 65536 (see Additional Information below).

SOFTWARE/OS VERSIONS

Linux: Debian sid, Linux kernel 5.13.10
KDE Plasma Version: 5.22.5
KDE Frameworks Version: 5.85.0
Qt Version: 5.15.2

ADDITIONAL INFORMATION

While the idea of validating port numbers is nice, the issue with getting too specific with it is that the range for non-ephemeral ports can vary by platform and individual system configuration. For Linux in particular, the default range for ephemeral ports (configurable via procfs /proc/sys/net/ipv4/ip_local_port_range) is 32768-60999, allowing ports 1 through 32767 to be used for anything else. Meanwhile, IANA recommends people to use 49152-65535 for ephemeral ports.

The validation check can be changed to accept port numbers with 5 digits instead of 4 since port numbers are currently 16-bit unsigned integers. If the devs prefer, the port number can be checked to be less than or equal than 65535, but again getting more specific than that is bound to cause incompatibilities with edge cases.