Bug 441777

Summary: System crashes if to insert other kdenlive file from project bin into timeline
Product: [Applications] kdenlive Reporter: squarepusher782
Component: User Interface & MiscellaneousAssignee: Jean-Baptiste Mardelle <jb>
Status: CLOSED FIXED    
Severity: crash CC: fritzibaby, julius.kuenzel, squarepusher782
Priority: NOR Flags: fritzibaby: timeline_corruption+
Version First Reported In: 21.08.0   
Target Milestone: ---   
Platform: Other   
OS: Microsoft Windows   
Latest Commit: Version Fixed In:
Sentry Crash Report:

Description squarepusher782 2021-08-30 19:46:26 UTC
SUMMARY


STEPS TO REPRODUCE
1. Create a project with some content, save as kdenlive file.
2. Create one more project, insert the project above into timeline.

OBSERVED RESULT
System crashes

EXPECTED RESULT
The movie is inserted into timeline(like it worked in previous versions)

SOFTWARE/OS VERSIONS
Windows: 
macOS: 
Linux/KDE Plasma: 
(available in About System)
KDE Plasma Version: 
KDE Frameworks Version: 
Qt Version: 

ADDITIONAL INFORMATION
Comment 1 Julius Künzel 2021-09-24 23:18:33 UTC
Thanks for your report! I can confirm this problem.
Comment 2 Jean-Baptiste Mardelle 2021-09-25 04:27:28 UTC
Git commit 36283985381c6fbd15004138cb68297d05b2d8e8 by Jean-Baptiste Mardelle.
Committed on 25/09/2021 at 04:26.
Pushed by mardelle into branch 'master'.

Remove broken "duplicate bin clip with timeremap" stuff that caused crash dropping playlists in timeline
FIXED-IN:

M  +0    -37   src/bin/bin.cpp
M  +0    -2    src/bin/bin.h
M  +2    -16   src/bin/projectclip.cpp
M  +0    -6    src/mainwindow.cpp

https://invent.kde.org/multimedia/kdenlive/commit/36283985381c6fbd15004138cb68297d05b2d8e8
Comment 3 Jean-Baptiste Mardelle 2021-09-26 06:25:53 UTC
Git commit 82df289b43163486ca0ceaa656726021ef9ed3ac by Jean-Baptiste Mardelle.
Committed on 26/09/2021 at 06:22.
Pushed by mardelle into branch 'release/21.08'.

Remove broken "duplicate bin clip with timeremap" stuff that caused crash dropping playlists in timeline
FIXED-IN:

M  +0    -37   src/bin/bin.cpp
M  +0    -2    src/bin/bin.h
M  +2    -16   src/bin/projectclip.cpp
M  +0    -6    src/mainwindow.cpp

https://invent.kde.org/multimedia/kdenlive/commit/82df289b43163486ca0ceaa656726021ef9ed3ac
Comment 4 squarepusher782 2021-09-28 19:11:54 UTC
Now the system does not crash and allows to insert a file into timeline. Thank you for what you are doing!
Once dragndrop unlocked some fixed files cannot be inserted while other are inserted succesfully. The message is "Cannot open file ...". The same file can be opened in standalone editor. Will search for identical tickets or report a new bug. Thanks!
Comment 5 Julius Künzel 2021-09-29 09:29:41 UTC
Thanks for the feedback! The reason for the "Cannot open file ..." message could be that the *.kdenlive file has a different frame rate than the project you want to insert the file to. Usually the error message should tell you this, but it turned out that it was broken since 21.08.0 and I fixed it yesterday so please update the nightly (at least windows build #899) and try again (https://binary-factory.kde.org/job/Kdenlive_Nightly_mingw64/)