Bug 441742

Summary:	Accessibility Features in Response window are missing
Product:	[Applications] kdeconnect	Reporter:	Jacob S. <jakieschneider13>
Component:	messaging-application	Assignee:	Simon Redman <simon>
Status:	RESOLVED FIXED
Severity:	minor	CC:	nicolas.fella
Priority:	NOR
Version First Reported In:	1.10
Target Milestone:	---
Platform:	Kubuntu
OS:	Linux
Latest Commit:		Version Fixed/Implemented In:	21.08.2
Sentry Crash Report:

Description Jacob S. 2021-08-30 07:32:13 UTC

SUMMARY
When responding to a message through the KDEConnect service, the message field is missing many critical accessibility features, such as keyboard navigation.

STEPS TO REPRODUCE
1. Respond to a message received from the android device through Connect
2. Use navigation keys such as `tab` or `enter`

OBSERVED RESULT
Keys used appear as characters.

EXPECTED RESULT
`tab` or `enter` key presses should in some way allow keyboard-navigation. Perhaps `shift`+`<key>` would type that character.

SOFTWARE/OS VERSIONS
Windows: Windows 10 21H1
macOS: 
Linux/KDE Plasma: KUbuntu 21.04 - Plasma 5.12

ADDITIONAL INFORMATION
General Accessibility features are missing, however the example outlined above is most impactful.

Comment 1 Nicolas Fella 2021-09-22 12:54:15 UTC

Pressing Tab enters a tab character into the textfield, which sounds kinda expected to me.

Using Shift+Tab focuses the Send button and using enter activates it

I think changing the enter behavior to send and inserting a line break would make sense, that's how lots of messaging apps work.

I'm not so sure about doing the same for tab, but I don't have a strong opinion on it

Comment 2 Nicolas Fella 2021-09-22 12:56:13 UTC

Then again this is not a text editor where entering a tab character is important.

I will ask some people for feedback

Comment 3 Nicolas Fella 2021-09-22 13:55:09 UTC

Merge requests for

changing tab behavior: https://invent.kde.org/network/kdeconnect-kde/-/merge_requests/423

changing enter behavior: https://invent.kde.org/network/kdeconnect-kde/-/merge_requests/424

Comment 4 Nicolas Fella 2021-09-23 13:36:30 UTC

Git commit 695e36755b2d9779a67e144cc54b9cccc28c6e51 by Nicolas Fella.
Committed on 22/09/2021 at 13:45.
Pushed by nicolasfella into branch 'master'.

[sendreplydialog] Submit on enter, enter newline on shift+enter

This enables better keyboard navigation and is consistent with virtually all messaging apps

M  +23   -0    plugins/notifications/sendreplydialog.cpp
M  +12   -0    plugins/notifications/sendreplydialog.h
M  +8    -1    plugins/notifications/sendreplydialog.ui

https://invent.kde.org/network/kdeconnect-kde/commit/695e36755b2d9779a67e144cc54b9cccc28c6e51

Comment 5 Nicolas Fella 2021-09-23 13:39:51 UTC

Git commit 1cf0eaba39b081380cd21b5a16697952a40bb1cb by Nicolas Fella.
Committed on 23/09/2021 at 13:37.
Pushed by nicolasfella into branch 'release/21.08'.

[sendreplydialog] Submit on enter, enter newline on shift+enter

This enables better keyboard navigation and is consistent with virtually all messaging apps
(cherry picked from commit 695e36755b2d9779a67e144cc54b9cccc28c6e51)

M  +23   -0    plugins/notifications/sendreplydialog.cpp
M  +12   -0    plugins/notifications/sendreplydialog.h
M  +8    -1    plugins/notifications/sendreplydialog.ui

https://invent.kde.org/network/kdeconnect-kde/commit/1cf0eaba39b081380cd21b5a16697952a40bb1cb

Comment 6 Nicolas Fella 2021-09-26 17:28:23 UTC

Git commit ee85a5d56e1eb4ac20da6fb288ace9240cb72232 by Nicolas Fella.
Committed on 26/09/2021 at 17:27.
Pushed by nicolasfella into branch 'master'.

[sendreplydialog] Move focus on tab

Currently pressing tab inserts a tab character. To enable keyboard navigation it should however focus the next item in the focus chain (the send button). Given that this is a simple reply to a text message and not a fully fledged text editor there's probably no need to insert a tab character anyway

M  +5    -1    plugins/notifications/sendreplydialog.ui

https://invent.kde.org/network/kdeconnect-kde/commit/ee85a5d56e1eb4ac20da6fb288ace9240cb72232

Comment 7 Nicolas Fella 2021-09-26 17:31:09 UTC

Git commit b1310bf1d12a3eb73d9776678bd9c222227707ad by Nicolas Fella.
Committed on 26/09/2021 at 17:29.
Pushed by nicolasfella into branch 'release/21.08'.

[sendreplydialog] Move focus on tab

Currently pressing tab inserts a tab character. To enable keyboard navigation it should however focus the next item in the focus chain (the send button). Given that this is a simple reply to a text message and not a fully fledged text editor there's probably no need to insert a tab character anyway
(cherry picked from commit ee85a5d56e1eb4ac20da6fb288ace9240cb72232)

M  +5    -1    plugins/notifications/sendreplydialog.ui

https://invent.kde.org/network/kdeconnect-kde/commit/b1310bf1d12a3eb73d9776678bd9c222227707ad