Bug 441740

Summary:	Add icon to install
Product:	[Applications] Skanlite	Reporter:	Justin Zobel <justin.zobel>
Component:	general	Assignee:	Kåre Särs <kare.sars>
Status:	RESOLVED FIXED
Severity:	normal
Priority:	NOR
Version First Reported In:	21.08.0
Target Milestone:	---
Platform:	Other
OS:	Linux
Latest Commit:	https://invent.kde.org/graphics/skanlite/commit/1c111a82f7d0880777090e300f2fb434fbca9776	Version Fixed/Implemented In:
Sentry Crash Report:

Description Justin Zobel 2021-08-30 07:22:29 UTC

Flatpaks need an icon when being installed.

There is an icon in the repository https://invent.kde.org/graphics/skanlite/-/blob/master/logo.png but it's not installed into /usr/share/icons during build.

Last build (several failed): https://binary-factory.kde.org/view/Flatpak/job/Skanlite_x86_64_flatpak/29/console
20:28:30  Error loading desktop file: Failed to find icon: Failed to find icon skanlite

Comment 1 Bug Janitor Service 2021-08-30 11:44:59 UTC

A possibly relevant merge request was started @ https://invent.kde.org/graphics/skanlite/-/merge_requests/15

Comment 2 Nicolas Fella 2021-09-05 20:36:08 UTC

Git commit 1c111a82f7d0880777090e300f2fb434fbca9776 by Nicolas Fella.
Committed on 05/09/2021 at 20:35.
Pushed by nicolasfella into branch 'master'.

Install app icon

Currently we rely on the 'skanlite' icon being shipped by breeze-icons,
which causes trouble when using Skanlite outside of Plasma or from
Flatpak.

Install the app icon to the hicolor theme to make sure it's always
available.

The icon file is copied from breeze-icons

A  +51   -0    48-apps-org.kde.skanlite.svg
M  +3    -0    CMakeLists.txt
M  +1    -1    src/org.kde.skanlite.desktop

https://invent.kde.org/graphics/skanlite/commit/1c111a82f7d0880777090e300f2fb434fbca9776