Summary: | Imgur loading without confirmation and deletion hash | ||
---|---|---|---|
Product: | [Applications] gwenview | Reporter: | uglic |
Component: | general | Assignee: | Gwenview Bugs <gwenview-bugs-null> |
Status: | RESOLVED FIXED | ||
Severity: | grave | CC: | joseskvolpe, omerusta |
Priority: | NOR | ||
Version: | 21.08.0 | ||
Target Milestone: | --- | ||
Platform: | Manjaro | ||
OS: | Linux | ||
Latest Commit: | https://invent.kde.org/frameworks/purpose/commit/77f636fd4bdb338f6d621bfca651db5dfa2fa952 | Version Fixed In: | |
Attachments: | Menu screenshot |
Description
uglic
2021-08-26 11:36:14 UTC
Git commit c22b558f006bf8677b0639af2b97f71a0a3dfe6f by Ömer Fadıl USTA. Committed on 27/08/2021 at 08:06. Pushed by usta into branch 'master'. [Imgur Share] Added support to fetch DeleteUrl for Share In case of User share a photo, it is his/her/its right to have image's deleteUrl so he/she/it can able to delete uploaded Image M +15 -5 app/mainwindow.cpp https://invent.kde.org/graphics/gwenview/commit/c22b558f006bf8677b0639af2b97f71a0a3dfe6f Hi Uglic , I have partially fixed your problem , I didnt add extra confirmation dialog because if a user selects share it mean he/she/it want to share and dont want to add extra are you sure part. But you were right , he/she/it has to have right to delete uploaded image so i added support to get deleteURL. On the other hand, share functionality is coming from "KF purpose" not directly from gwenview thus i added missing deletehash and deleteUrl parts to purpose and it will be enabled whenever KF 5.86 released ( and whenever your distro start to use it ) So as a short explanation if anyone builds from git versions of KF and gwenview they will have this functionality but normal end users will wait until first release. Git commit 77f636fd4bdb338f6d621bfca651db5dfa2fa952 by Nicolas Fella. Committed on 13/12/2021 at 20:39. Pushed by ngraham into branch 'master'. [imgur] Show deletion url in notification This allows users to undo the upload Related: bug 394181 M +4 -1 src/plugins/imgur/imgurplugin.cpp https://invent.kde.org/frameworks/purpose/commit/77f636fd4bdb338f6d621bfca651db5dfa2fa952 (In reply to Ömer Fadıl USTA from comment #2) >I didnt add extra > confirmation dialog because if a user selects share it mean he/she/it want > to share and dont want to add extra are you sure part. The problem is a user could select "Share to Imgur" accidentally, with the intention to select any other thing (like "Share to device" KDE Connect option), yet all other options shows a dialog to confirm the send and fill entries to where and who would you like to send, it's only Share to Imgur that doesn't do it. I've accidentaly uploaded a picture to Imgur once when my intention was to share to Bluetooth device, what saved me was the option to delete the picture. Still, there's other issue: ¿how can i guarantee my picture is not still stored in their servers, even after deletion? It's known that some providers backup data for a period after deletion. I still think it should have a confirmation dialog, or maybe, instead of "Share to Imgur", there be a "Share online" option with a dialog asking wich service would you like to use. |