Bug 441534

Summary:	Update test results for test_isa_3_1_VRT to match changed inputs
Product:	[Developer tools] valgrind	Reporter:	Will Schmidt <will_schmidt>
Component:	general	Assignee:	Julian Seward <jseward>
Status:	CLOSED FIXED
Severity:	normal	CC:	cel, jseward, will_schmidt
Priority:	NOR
Version First Reported In:	unspecified
Target Milestone:	---
Platform:	Other
OS:	Linux
Latest Commit:		Version Fixed In:
Sentry Crash Report:
Attachments:	Proposed patch to update the vinsd* instruction test results test_isa_3_1_VRT.stdout.exp

Description Will Schmidt 2021-08-25 16:04:12 UTC

Created attachment 141038 [details]
Proposed patch to update the vinsd* instruction test results test_isa_3_1_VRT.stdout.exp

SUMMARY

The inputs into the vinsdlx,vinsdrx instructions changed, and the test results
were not updated to match.  This addresses the issue.

STEPS TO REPRODUCE
1. Run none/tests/ppc64/test_isa_3_1_VRT test case
2. See failure in expected output.
3. 

OBSERVED RESULT
...
> -vinsdlx 4 0 => 1111111100000000,0000000011111111
> -vinsdlx 4 2 => 1111111100000000,0000000211111111
...
> +vinsdlx 6 0 => 1111111111110000,0000000000001111
> +vinsdlx 6 2 => 1111111111110000,0000000000021111
...


EXPECTED RESULT
Success.

SOFTWARE/OS VERSIONS
Windows: 
macOS: 
Linux/KDE Plasma: 
(available in About System)
KDE Plasma Version: 
KDE Frameworks Version: 
Qt Version: 

ADDITIONAL INFORMATION
Proposed patch attached.

Comment 1 Will Schmidt 2021-09-07 17:30:39 UTC

Per some additional investigation, the changed inputs to the vinsd* tests are a side affect of changes made as part of bug 440906, which affected a modulo operation occurring on hard registers.

Comment 2 Carl Love 2021-09-07 18:40:41 UTC

Proposed patch tested, reviewed and committed.

commit 9aaeafa70c5126b22857485449f8d5eeb1d9c527 (HEAD -> master, origin/master, origin/HEAD)
Author: Carl Love <cel@us.ibm.com>
Date:   Tue Sep 7 17:15:38 2021 +0000

    Update the expected output for test_isa_3_1_VRT.
    
    The inputs into the vinsdlx,vinsdrx instructions changed as a result of
    the impossible constraint issue fix.  This patch updates the expected
    results.
    
    https://bugs.kde.org/show_bug.cgi?id=441534

Comment 3 Carl Love 2021-09-30 22:15:51 UTC

Copied the wrong link in the previous comment.  See

https://bugs.kde.org/show_bug.cgi?id=443035
for the fix.