| Summary: | remove troublesome block of code from guest_ppc_toIR code for pstxvp instruction | ||
|---|---|---|---|
| Product: | [Developer tools] valgrind | Reporter: | Will Schmidt <will_schmidt> |
| Component: | general | Assignee: | Julian Seward <jseward> |
| Status: | REPORTED --- | ||
| Severity: | normal | CC: | cel, jseward, will_schmidt |
| Priority: | NOR | ||
| Version First Reported In: | unspecified | ||
| Target Milestone: | --- | ||
| Platform: | Other | ||
| OS: | Linux | ||
| Latest Commit: | Version Fixed/Implemented In: | ||
| Sentry Crash Report: | |||
| Attachments: | proposed patch to remove improper R=1 check and return. | ||
Proposed patch reviewed, tested and committed. commit 041f6c19a0cd40fe684571c380399be518b8d6b2 (HEAD -> master, origin/master, origin/HEAD) Author: Carl Love <cel@us.ibm.com> Date: Fri Sep 3 16:36:31 2021 +0000 Remove a unneeded / unnecessary prefix check. The pstxvp instruction is valid for R=1, i.e. use pc relative addressing. The test should have been remmoved before committing the ISA 3.1 support. https://bugs.kde.org/show_bug.cgi?id=441512 |
Created attachment 141023 [details] proposed patch to remove improper R=1 check and return. SUMMARY A chunk of code was committed that should have been removed during initial development of support for the pstxvp instruction. This chunk of code prevents the emulation of the pstxvp instruction, which is showing up in current builds targeting the power10 platform. STEPS TO REPRODUCE 1. Build valgrind on/for a Power10 system. 2. Run testsuite (test_isa_3_1_XT) or other tests utilizing the pstxvp instruction. 3. OBSERVED RESULT failure. EXPECTED RESULT success. SOFTWARE/OS VERSIONS Windows: macOS: Linux/KDE Plasma: (available in About System) KDE Plasma Version: KDE Frameworks Version: Qt Version: ADDITIONAL INFORMATION Proposed patch attached.