Bug 441473

Summary:	Impasto Brush is producing strange kind of space/blob effect
Product:	[Applications] krita	Reporter:	IForce73 <uenvironments>
Component:	Brush engines	Assignee:	Krita Bugs <krita-bugs-null>
Status:	RESOLVED FIXED
Severity:	normal	CC:	halla
Priority:	NOR
Version:	5.0.0-beta1
Target Milestone:	---
Platform:	Microsoft Windows
OS:	Microsoft Windows
Latest Commit:		Version Fixed In:
Sentry Crash Report:
Attachments:	Left Krita 4, right Krita 5 Screenshot from mail Screenshot from mail

Description IForce73 2021-08-24 10:50:55 UTC

Stranhe Brush behaviour after loading preset from "Experimental Oils" Bundle


STEPS TO REPRODUCE
1. loading any preset from "experimental oils" bundle
2. brush stroke is producing a strange space/blob effect
3. after changing the space in the brush settings it works okay

OBSERVED RESULT

Brush stroke is producing strange space in the stroke


EXPECTED RESULT


SOFTWARE/OS VERSIONS
Windows: 10
macOS: 
Linux/KDE Plasma: 
(available in About System)
KDE Plasma Version: 
KDE Frameworks Version: 
Qt Version: 

ADDITIONAL INFORMATION

haven't tested it yet with any other impasto preset but i guess that's happening with any other impasto brush too.

Comment 1 Halla Rempt 2021-08-24 11:50:37 UTC


*** This bug has been marked as a duplicate of bug 441347 ***

Comment 2 Halla Rempt 2021-08-24 11:51:14 UTC

The brush tips aren't found:

en shared object file: No such file or directory)"
                Could not set current file 0 "brushes/bristles_circle_dense.png"
Bundle "/home/halla/.local/share/krita/Experimental_Oils_IForce73.bundle" is broken. File "brushes/bristles_circle_dense.png" is missing
                Could not set current file 0 "brushes/bristles_circle_medium.png"
Bundle "/home/halla/.local/share/krita/Experimental_Oils_IForce73.bundle" is broken. File "brushes/bristles_circle_medium.png" is missing
                Could not set current file 0 "brushes/chalk.png"
Bundle "/home/halla/.local/share/krita/Experimental_Oils_IForce73.bundle" is broken. File "brushes/chalk.png" is missing
                Could not set current file 0 "brushes/freckles.png"
Bundle "/home/halla/.local/share/krita/Experimental_Oils_IForce73.bundle" is broken. File "brushes/freckles.png" is missing
                Could not set current file 0 "brushes/noise.gih"
Bundle "/home/halla/.local/share/krita/Experimental_Oils_IForce73.bundle" is broken. File "brushes/noise.gih" is missing
                Could not set current file 0 "brushes/scales.png"
Bundle "/home/halla/.local/share/krita/Experimental_Oils_IForce73.bundle" is broken. File "brushes/scales.png" is missing
                Could not set current file 0 "brushes/smear_paint.png"
Bundle "/home/halla/.local/share/krita/Experimental_Oils_IForce73.bundle" is broken. File "brushes/smear_paint.png" is missing
                Could not set current file 0 "brushes/spines.png"
Bundle "/home/halla/.local/share/krita/Experimental_Oils_IForce73.bundle" is broken. File "brushes/spines.png" is missing
                Could not set current file 0 "brushes/splats_large.gih"
Bundle "/home/halla/.local/share/krita/Experimental_Oils_IForce73.bundle" is broken. File "brushes/splats_large.gih" is missing
                Could not set current file 0 "brushes/square_eroded.png"
Bundle "/home/halla/.local/share/krita/Experimental_Oils_IForce73.bundle" is broken. File "brushes/square_eroded.png" is missing
                Could not set current file 0 "brushes/watercolor.gih"
Bundle "/home/halla/.local/share/krita/Experimental_Oils_IForce73.bundle" is broken. File "brushes/watercolor.gih" is missing

But in any case, this was reported before, and I am looking into it.

Comment 3 Halla Rempt 2021-08-24 11:55:55 UTC

No... It's not a duplicate. The bundle itself lists brush tips in the manifest that do not exist:

 <manifest:file-entry manifest:media-type="brushes" manifest:full-path="brushes/bristles_circle_dense.png" manifest:md5sum="2077c6167d084a057a8b486317faee70"/>
 <manifest:file-entry manifest:media-type="brushes" manifest:full-path="brushes/bristles_circle_medium.png" manifest:md5sum="1c0f289e766a9e0408a3d85ad2ea6d71"/>
 <manifest:file-entry manifest:media-type="brushes" manifest:full-path="brushes/chalk.png" manifest:md5sum="0ff46e2283e042d178eb38ea48567c7e"/>
 <manifest:file-entry manifest:media-type="brushes" manifest:full-path="brushes/freckles.png" manifest:md5sum="6f59df30f0fd8d3f3585a588149e36b0"/>
 <manifest:file-entry manifest:media-type="brushes" manifest:full-path="brushes/noise.gih" manifest:md5sum="e5c4072a5f5cd90e059515d606aecb0b"/>
 <manifest:file-entry manifest:media-type="brushes" manifest:full-path="brushes/scales.png" manifest:md5sum="5c729dd25103ea3b727949146cfe5f45"/>
 <manifest:file-entry manifest:media-type="brushes" manifest:full-path="brushes/smear_paint.png" manifest:md5sum="53c99fbaf77962937bb64307a9f54f55"/>
 <manifest:file-entry manifest:media-type="brushes" manifest:full-path="brushes/spines.png" manifest:md5sum="3af0ab5a11b704e562c04612389f9ec9"/>
 <manifest:file-entry manifest:media-type="brushes" manifest:full-path="brushes/splats_large.gih" manifest:md5sum="ee65dd9910dc474f85bb5ce26353f40c"/>
 <manifest:file-entry manifest:media-type="brushes" manifest:full-path="brushes/square_eroded.png" manifest:md5sum="d0c61f7db346b848c4685310e6342c74"/>
 <manifest:file-entry manifest:media-type="brushes" manifest:full-path="brushes/watercolor.gih" manifest:md5sum="ab0f2533f70f76314711899bec6b34cb"/>


(those are brush tips from the krita4 default bundle.)

Comment 4 Halla Rempt 2021-08-24 12:17:42 UTC

Created attachment 141005 [details]
Left Krita 4, right Krita 5

I'm not sure i actually see much of a difference?

Comment 5 Halla Rempt 2021-08-24 12:21:33 UTC

Git commit ec904eba1b6c282302a8e6908bbdda23301a3438 by Halla Rempt.
Committed on 24/08/2021 at 12:21.
Pushed by rempt into branch 'master'.

On loading a bundle, remove resources that are missing from the manifest

M  +2    -4    libs/resources/KoResourceBundle.cpp
M  +9    -0    libs/resources/KoResourceBundleManifest.cpp
M  +1    -1    libs/resources/KoResourceBundleManifest.h

https://invent.kde.org/graphics/krita/commit/ec904eba1b6c282302a8e6908bbdda23301a3438

Comment 6 Halla Rempt 2021-08-24 12:21:46 UTC

Git commit 1455dc6e5b57dec38ec03cebe8192582e04382a2 by Halla Rempt.
Committed on 24/08/2021 at 12:21.
Pushed by rempt into branch 'krita/5.0'.

On loading a bundle, remove resources that are missing from the manifest
(cherry picked from commit ec904eba1b6c282302a8e6908bbdda23301a3438)

M  +2    -4    libs/resources/KoResourceBundle.cpp
M  +9    -0    libs/resources/KoResourceBundleManifest.cpp
M  +1    -1    libs/resources/KoResourceBundleManifest.h

https://invent.kde.org/graphics/krita/commit/1455dc6e5b57dec38ec03cebe8192582e04382a2

Comment 7 Halla Rempt 2021-08-24 12:25:30 UTC

Could you attach a screenshot that shows the problem?

Comment 8 Halla Rempt 2021-08-25 08:22:44 UTC

Created attachment 141027 [details]
Screenshot from mail

Comment 9 Halla Rempt 2021-08-25 08:23:03 UTC

Created attachment 141028 [details]
Screenshot from mail

Comment 10 Halla Rempt 2021-08-25 08:29:06 UTC

Hm, I cannot reproduce that myself with your brush set.

Comment 11 Halla Rempt 2022-06-28 11:57:58 UTC

I tested this again, and it looks fixed to me.