| Summary: | add "Ctrl + Shift + ," as default shortcut to open Konfigurator | ||
|---|---|---|---|
| Product: | [Applications] krusader | Reporter: | empyreal <empyreal> |
| Component: | general | Assignee: | Krusader Bugs Distribution List <krusader-bugs-null> |
| Status: | RESOLVED FIXED | ||
| Severity: | wishlist | CC: | davide, krusader-bugs-null, omerusta, toni.asensi |
| Priority: | NOR | ||
| Version First Reported In: | unspecified | ||
| Target Milestone: | --- | ||
| Platform: | Kubuntu | ||
| OS: | Linux | ||
| Latest Commit: | Version Fixed In: | ||
| Sentry Crash Report: | |||
|
Description
empyreal
2021-08-21 18:42:56 UTC
Good point, as I can see, this is the default for the majority of kde applications. Fixed with https://invent.kde.org/utilities/krusader/-/commit/874543bbe1c8d4be6ed054a7b0f4d5153e26cfc7 Git commit 4b8d770008426f7b805571956553751779900653 by Toni Asensi Esteve, on behalf of Davide Gianforte. Committed on 24/08/2021 at 21:35. Pushed by asensi into branch 'mr/66'. Fix build for KF < 5.64 The last commit introduced a method which require at least KF 5.64, making Krusader unable to compile with older releases. GUI: 'Ctrl+Shift+,' is now seen as the shortcut to configure Krusader, following the standard. M +1 -1 krusader/kractions.cpp https://invent.kde.org/utilities/krusader/commit/4b8d770008426f7b805571956553751779900653 @Toni and @Davide Thank you for fixing for KF < 5.64 but it looks like you merge it into a branch named mr/66 instead of master. > @Toni and @Davide Thank you for fixing for KF < 5.64
> but it looks like you merge it into a branch named mr/66 instead of master.
Thanks for writing, Ömer. The idea was not merging the branch named "mr/66" (with Davide's proposal) to master --because the MR 66 still may be reviewed by other people. I wanted to add those two lines to the commit:
GUI: 'Ctrl+Shift+,' is now seen as the shortcut to configure Krusader, following the standard.
CCBUG: 441320
and so I executed
git mr 66
git commit --amend
git push origin mr/66
although it had an unintended effect.
@Toni i am also sorry not to wait for a review so i merge that fix (happend with a little excitement) I am really sorry for the people who are still using older versions of KF You don't have to worry, Ömer. Next time, you can create a MR and other developers can write ideas there before merging. Cheers! Git commit 651598011456664359a6c48c5358bc7da0d27fa2 by Davide Gianforte. Committed on 25/08/2021 at 06:46. Pushed by gengisdave into branch 'master'. Fix build for KF < 5.64 The last commit introduced a method which require at least KF 5.64, making Krusader unable to compile with older releases. GUI: 'Ctrl+Shift+,' is now seen as the shortcut to configure Krusader, following the standard. M +1 -1 krusader/kractions.cpp https://invent.kde.org/utilities/krusader/commit/651598011456664359a6c48c5358bc7da0d27fa2 |