Bug 441316

Summary: Aspect-ratio cropping does not show a frame to select the crop
Product: [Applications] digikam Reporter: Wolfgang Klein <klein.wolfg>
Component: Plugin-Editor-CropAssignee: Digikam Developers <digikam-bugs-null>
Status: RESOLVED FIXED    
Severity: normal CC: caulier.gilles, metzpinguin
Priority: NOR    
Version First Reported In: 7.3.0   
Target Milestone: ---   
Platform: Other   
OS: Linux   
Latest Commit: Version Fixed/Implemented In: 7.4.0
Sentry Crash Report:
Attachments: my digikamrc

Description Wolfgang Klein 2021-08-21 17:40:19 UTC
SUMMARY

When aspect ration crop is chosen, the whole image is just greyed out and there's no cutting frame that can be pulled or positioned

STEPS TO REPRODUCE
1. Load an image in the editor
2. Select crop by aspect ration
3. Be puzzled

OBSERVED RESULT


EXPECTED RESULT

I would expect to be able to select the crop by drawing or scaling a frame around the desired area.

SOFTWARE/OS VERSIONS
Linux/KDE Plasma: KDE Neon
KDE Plasma Version: 5.22.4 
KDE Frameworks Version: 5.85.0
Qt Version: 5.15.3

ADDITIONAL INFORMATION
Cropping used to work as expected before the latest update.
Comment 1 caulier.gilles 2021-08-22 05:02:05 UTC
There is a button "Defaults" on the bottom of settings panel from the crop tool. This will reset the crop view.

You can also use the "Max Aspect" button to use the the aspect ratio on the image with the maximum area possible to apply.

In both cases, this will make the crop view visible.

Gilles Caulier
Comment 2 Wolfgang Klein 2021-08-22 05:41:26 UTC
Neither button changes anything: the image is still being greyed like looking through a pane of glass, and I still can't draw a rectangle with the mouse.
Comment 3 Wolfgang Klein 2021-08-22 05:43:55 UTC
One thing changes, though, when I hit any of those two buttons: the values in the fields "position" and "size", but like I said: still no crop rectangle is shown.
Comment 4 Maik Qualmann 2021-08-22 07:42:12 UTC
I recently had this problem with one of my test configurations. Delete the area of the "[aspectratiocrop Tool]" section in the digikamrc. Please post the section here so we can investigate.

Maik
Comment 5 Maik Qualmann 2021-08-22 08:17:32 UTC
Git commit 2fb25486774a4090ea8be6d47dcffe1d1500349f by Maik Qualmann.
Committed on 22/08/2021 at 08:16.
Pushed by mqualmann into branch 'master'.

fix the non restore settings mode with the Aspect-ratio Tool
FIXED-IN: 7.4.0

M  +1    -1    NEWS
M  +6    -0    core/dplugins/editor/transform/ratiocrop/ratiocroptool.cpp

https://invent.kde.org/graphics/digikam/commit/2fb25486774a4090ea8be6d47dcffe1d1500349f
Comment 6 Wolfgang Klein 2021-08-22 09:08:44 UTC
Created attachment 140933 [details]
my digikamrc
Comment 7 Wolfgang Klein 2021-08-22 09:12:22 UTC
Comment on attachment 140933 [details]
my digikamrc

Ups, I wanted to add some text to the attachment. Here's the section you asked for. But even after deleting the whole section the crop tool is still unusable. The attachment is the digikamrc *after* deleting the section.

[aspectratiocrop Tool]
Auto Orientation=false
CompositionGuide Expanded=true
CropInformation Expanded=true
CropSelection Expanded=true
Golden Flip Horizontal=false
Golden Flip Vertical=false
Golden Section=false
Golden Spiral=false
Golden Spiral Section=false
Golden Triangle=false
Guide Color=250,250,255
Guide Lines Type=3
Guide Width=1
Histogram Channel=0
Histogram Scale=1
Hor.Oriented Aspect Ratio=11
Hor.Oriented Aspect Ratio Orientation=0
Hor.Oriented Custom Aspect Ratio Den=1
Hor.Oriented Custom Aspect Ratio Height=1694
Hor.Oriented Custom Aspect Ratio Num=1
Hor.Oriented Custom Aspect Ratio Width=3012
Hor.Oriented Custom Aspect Ratio Xpos=2826
Hor.Oriented Custom Aspect Ratio Ypos=252
Precise Aspect Ratio Crop=false
Ver.Oriented Aspect Ratio=5
Ver.Oriented Aspect Ratio Orientation=0
Ver.Oriented Custom Aspect Ratio Den=1
Ver.Oriented Custom Aspect Ratio Height=600
Ver.Oriented Custom Aspect Ratio Num=1
Ver.Oriented Custom Aspect Ratio Width=800
Ver.Oriented Custom Aspect Ratio Xpos=50
Ver.Oriented Custom Aspect Ratio Ypos=50
Comment 8 Maik Qualmann 2021-08-22 09:18:48 UTC
Yes, you have deactivated restoring the last tool settings:

RestoreToolSettings=false

The problem has now been resolved.

Maik
Comment 9 Maik Qualmann 2021-08-22 09:22:56 UTC
The "[aspectratiocrop Tool]" section was not the problem, for now you can re-enable the restore of the last tool settings as a workaround up to the digiKam-7.4.0 version.

Maik
Comment 10 Wolfgang Klein 2021-08-22 09:32:54 UTC
Oh, yes, thank you! Deleting that line did the trick.

Honestly, I can not remember setting that option!