| Summary: | Activation feels too slow | ||
|---|---|---|---|
| Product: | [Plasma] kwin | Reporter: | Nate Graham <nate> |
| Component: | effects-overview | Assignee: | KWin default assignee <kwin-bugs-null> |
| Status: | RESOLVED FIXED | ||
| Severity: | minor | CC: | kde, kinofhek |
| Priority: | NOR | ||
| Version First Reported In: | git master | ||
| Target Milestone: | --- | ||
| Platform: | Other | ||
| OS: | Linux | ||
| Latest Commit: | https://invent.kde.org/plasma/kwin/commit/205fb923cb8e1cbc0d26edc5a2ce37784ac32b41 | Version Fixed/Implemented In: | 5.23 |
| Sentry Crash Report: | |||
|
Description
Nate Graham
2021-08-21 16:34:13 UTC
HIG says if an item moves but stays visible to ease both in and out. https://develop.kde.org/hig/style/animations/ It does, but in this case using an ease-in just doesn't feel right to me. It makes the overall effect feel sluggish and unresponsive, like it took half a second to respond to your keypress. How does it feel to you? IMO current easing type feels nice to me, it feeling sluggish and unresponsive seems to come from some other factor. Maybe it's just a bit too slow... Indeed. The duration is 300, which simply matches the existing hardcoded duration of the old Present Windows effect. This should be using a standard PlasmaCore.Units duration value, such as longDuration (200ms). Now it all makes sense for why it feels slow since the ease-in+ease-out behavior is calibrated for a fast overall duration, not a slow one. So the old 300ms with no ease-in feels faster than 300ms with an ease-in+ease-out. 200ms with an ease-in+ease-out feels a lot better in my testing. I'll work on a patch. >Maybe it's just a bit too slow...
It is currently set to a much higher value than the old effect
I guess that would explain it. Any reason why? A possibly relevant merge request was started @ https://invent.kde.org/plasma/kwin/-/merge_requests/1312 Git commit 205fb923cb8e1cbc0d26edc5a2ce37784ac32b41 by Nate Graham. Committed on 26/08/2021 at 16:15. Pushed by ngraham into branch 'master'. [effects/overview] Speed up animation The current duration is 300ms, which is inappropriate for two reasons: 1. It's too slow 2. It doesn't match one of the standard durations. The effect should ideally use those durations directly, but if this is not possible for technical reasons, it should use the effective value of one of those durations. Units.longDuration is 200ms which is the most appropriate one to use here. Therefore, change the animation duration from 300ms to 200ms to match the standard Units.longDuration duration. FIXED-IN: 5.23 M +1 -1 src/effects/overview/overvieweffect.cpp M +1 -1 src/effects/overview/overvieweffect.h https://invent.kde.org/plasma/kwin/commit/205fb923cb8e1cbc0d26edc5a2ce37784ac32b41 |