| Summary: | Detach/attach Brush Editor causes window glitches on macOS | ||
|---|---|---|---|
| Product: | [Applications] krita | Reporter: | apelsinchoklad |
| Component: | General | Assignee: | vanyossi <ghevan> |
| Status: | RESOLVED FIXED | ||
| Severity: | normal | CC: | ghevan, halla |
| Priority: | NOR | ||
| Version: | 5.0.0-beta1 | ||
| Target Milestone: | --- | ||
| Platform: | macOS (DMG) | ||
| OS: | macOS | ||
| Latest Commit: | https://invent.kde.org/graphics/krita/commit/5686325adb8cff44d62c2ae0b2f87e3e96e093ed | Version Fixed In: | |
| Sentry Crash Report: | |||
| Attachments: | Brush Editor window bug | ||
I cannot reproduce this issue on krita 5 beta on macos 11.5.2, and for the moment I cannot test this on High Sierra (10.13.6) which could be the potential issue. Is it possible for you to test on a more recent macOS? (In reply to vanyossi from comment #1) > I cannot reproduce this issue on krita 5 beta on macos 11.5.2, and for the > moment I cannot test this on High Sierra (10.13.6) which could be the > potential issue. > > Is it possible for you to test on a more recent macOS? I'd need a newer graphics card to upgrade this computer. And its about time :D I'll ask my sister. (I believe she run Mojave on her laptop but not sure.) I was able to reproduce the bug on another machine also running High Sierra however. (In reply to vanyossi from comment #1) On my sisters computer running macOS Mojave 10.14.6 the blank window is created but not the stuck drop shadow. Thanks for your comment! Automatically switching the status of this bug to REPORTED so that the KDE team knows that the bug is ready to get confirmed. In the future you may also do this yourself when providing needed information. On Mojava, I can reproduce: I set the brush editor to attached -- an empty window shows up where the editor dialog was, and that only goes away when I popup the editor again in its attached state. I don't have to restart Krita for that. I suspect that it's a bug in Qt, though. I can reproduce this on BigSur as well now. to make sure a left behind window is created do the steps, however since last compile am always getting a dummy window everytime I toggle the checkbox (as many windows as times toggled) 1. Select Detach Brush editor 2. Go Full screen 3. Activate brush editor, this will make focus move to the previous desktop to show the editor 4. Without leavinf FS: "Detach Brush editor" 5. A dummy/ghost empty window is left behind It seems as we are loosing the parent reference and not killing the window, need to check the code for that. Git commit 2ce5348f1c6b0a94c39da87881609033ced1cea2 by Ivan Yossi. Committed on 25/08/2021 at 18:51. Pushed by ivany into branch 'master'. Fix left behind brush preset window on macOS M +1 -1 libs/widgetutils/KisPopupButton.cpp https://invent.kde.org/graphics/krita/commit/2ce5348f1c6b0a94c39da87881609033ced1cea2 Git commit 5686325adb8cff44d62c2ae0b2f87e3e96e093ed by Ivan Yossi. Committed on 25/08/2021 at 18:54. Pushed by ivany into branch 'krita/5.0'. Fix left behind brush preset window on macOS M +1 -1 libs/widgetutils/KisPopupButton.cpp https://invent.kde.org/graphics/krita/commit/5686325adb8cff44d62c2ae0b2f87e3e96e093ed |
Created attachment 140914 [details] Brush Editor window bug SUMMARY When selecting the option to detach the Brush Editor the window drop shadow gets stuck on screen. When re-attached, a blank window is left that cannot be closed. Not persistent after Krita restart. SOFTWARE/OS VERSIONS macOS: 10.13.6 ADDITIONAL INFORMATION Video demo attached