Bug 441260

Created attachment 140883 [details]
"Mark Message" menu screenshot

(version: 5.18.0 [there's no such option in the Version field to choose])

For a message that's marked as important, its "Mark Message" menu presents a selected checkbox with "Remove Important Mark" label (see the attached screenshot).

That's... confusing. It suggests that removal of important mark is now being active, so effectively tells that the message is not marked as important, which isn't true. Unchecking it makes the label change to "Mark Message as Important", which makes much more sense.

The confusion comes from the fact that KMail presents an action-based wording in a context that strongly suggest a state-based one. Possible solutions:

- keep the label as "Mark Message as Important" and don't change it for messages already marked as such, as the checkbox already tells the user whether the message is marked or not and what will happen after toggling it

- remove the checkbox; keep the current label's behavior. This will make it clear that the label represents an action that happens after selecting it and not the current state.

- split the menu item into two items (mark / unmark) with only one enabled at once. As a bonus, this would make it consistent with "Mark Message as Read/Unread" entries right above.

The same issue applies to "Mark Message as Action Item" entry as well.