Summary: | Dolphin crashes after closing it while terminal is open. | ||
---|---|---|---|
Product: | [Applications] konsole | Reporter: | Tony <jodr666> |
Component: | kpart | Assignee: | Konsole Developer <konsole-devel> |
Status: | RESOLVED FIXED | ||
Severity: | crash | CC: | aalsing, alex765, bednarczyk.pawel, brandonmccoub, caiosantanaj, cullmann, dhirajhazra, emaster987, geraldo.simiao.kutz, igiwatson, joshuag1000, jpmbatrina01, kde, kfm-devel, ktsh.tanaka.2020, marschuhm, nate, nullrequest, painless.roaster, pizzadude, postix, quanticcpu2100, rjwgnr27, seqularise, tcanabrava |
Priority: | HI | Keywords: | regression |
Version: | 21.08.0 | ||
Target Milestone: | --- | ||
Platform: | openSUSE | ||
OS: | Linux | ||
Latest Commit: | https://invent.kde.org/utilities/konsole/commit/a731cd883304c2e00dce5210bc929a59d49736c2 | Version Fixed In: | 21.08.1 |
Attachments: |
New crash information added by DrKonqi
drkonki kcrash report New crash information added by DrKonqi |
Description
Tony
2021-08-20 00:35:21 UTC
This crash is occurring frequently for me on Dolphin 21.08.0 on Fedora 34 Wayland session. Can confirm. Moving to Konsole as I believe there were some relevant changes to the KPart which could have caused this. A possibly relevant merge request was started @ https://invent.kde.org/utilities/konsole/-/merge_requests/464 *** Bug 441290 has been marked as a duplicate of this bug. *** *** Bug 441586 has been marked as a duplicate of this bug. *** Git commit 2684bc7fa5ac0b740b3e8661c3a0ae0136fde0a7 by Ahmad Samir. Committed on 22/08/2021 at 18:10. Pushed by tcanabrava into branch 'master'. Only emit empty() in SessionFinished() when in TabbedNavigation mode empty() is emitted so that MainWindow calls close() and we get rid of the colours-flashing bug when closing the last session/tab in a window, see commit bbec72250d080. However all that isn't relevant when we are in konsole Part mode, where there are no tabs or MainWindows. This fixes a crash in Dolphin when closing its window while the embedded Konsole Part is open. The crash would happen as calling ViewContainer::currentTabViewCount() would end up in the ViewSplitter code path, which is no-op in Konsole Part. To test: - Open dolphin, make sure the terminal panel isn't open to begin with - open the terminal panel - close the dolphin window while the terminal panel is open FIXED-IN: 21.08.1 M +7 -5 src/ViewManager.cpp https://invent.kde.org/utilities/konsole/commit/2684bc7fa5ac0b740b3e8661c3a0ae0136fde0a7 Git commit a731cd883304c2e00dce5210bc929a59d49736c2 by Ahmad Samir. Committed on 27/08/2021 at 12:31. Pushed by ahmadsamir into branch 'release/21.08'. Only emit empty() in SessionFinished() when in TabbedNavigation mode empty() is emitted so that MainWindow calls close() and we get rid of the colours-flashing bug when closing the last session/tab in a window, see commit bbec72250d080. However all that isn't relevant when we are in konsole Part mode, where there are no tabs or MainWindows. This fixes a crash in Dolphin when closing its window while the embedded Konsole Part is open. The crash would happen as calling ViewContainer::currentTabViewCount() would end up in the ViewSplitter code path, which is no-op in Konsole Part. To test: - Open dolphin, make sure the terminal panel isn't open to begin with - open the terminal panel - close the dolphin window while the terminal panel is open FIXED-IN: 21.08.1 (cherry picked from commit 2684bc7fa5ac0b740b3e8661c3a0ae0136fde0a7) M +7 -5 src/ViewManager.cpp https://invent.kde.org/utilities/konsole/commit/a731cd883304c2e00dce5210bc929a59d49736c2 *** Bug 441545 has been marked as a duplicate of this bug. *** *** Bug 441549 has been marked as a duplicate of this bug. *** *** Bug 441620 has been marked as a duplicate of this bug. *** *** Bug 441856 has been marked as a duplicate of this bug. *** Created attachment 141259 [details]
New crash information added by DrKonqi
dolphin (21.08.0) using Qt 5.15.2
- What I was doing when the application crashed:
Pressed F4 and then clicked the red close button with my mouse and it said it crashed after I took a screenshot
-- Backtrace (Reduced):
#4 0x00007fce6165dc73 in QStackedLayout::widget(int) const () from /lib64/libQt5Widgets.so.5
#5 0x00007fce3822aa1d in Konsole::TabbedViewContainer::viewSplitterAt(int) () from /lib64/libkonsoleprivate.so.21
#6 0x00007fce3822d8a6 in Konsole::TabbedViewContainer::currentTabViewCount() () from /lib64/libkonsoleprivate.so.21
#7 0x00007fce381d5849 in Konsole::ViewManager::sessionFinished() () from /lib64/libkonsoleprivate.so.21
#8 0x00007fce60ad0c99 in void doActivate<false>(QObject*, int, void**) () from /lib64/libQt5Core.so.5
*** Bug 441933 has been marked as a duplicate of this bug. *** (In reply to Brandon McC from comment #12) > Created attachment 141259 [details] > New crash information added by DrKonqi > > dolphin (21.08.0) using Qt 5.15.2 > > -- Backtrace (Reduced): > #4 0x00007fce6165dc73 in QStackedLayout::widget(int) const () from /lib64/libQt5Widgets.so.5 > #5 0x00007fce3822aa1d in Konsole::TabbedViewContainer::viewSplitterAt(int) () from /lib64/libkonsoleprivate.so.21 Yep, this is the same crash. The fix is shipped with 21.08.1 which should be available soon (depending on your distro) *** Bug 442026 has been marked as a duplicate of this bug. *** *** Bug 442036 has been marked as a duplicate of this bug. *** *** Bug 442223 has been marked as a duplicate of this bug. *** *** Bug 442307 has been marked as a duplicate of this bug. *** *** Bug 442360 has been marked as a duplicate of this bug. *** *** Bug 442479 has been marked as a duplicate of this bug. *** *** Bug 442502 has been marked as a duplicate of this bug. *** *** Bug 442496 has been marked as a duplicate of this bug. *** *** Bug 442647 has been marked as a duplicate of this bug. *** Created attachment 141750 [details]
drkonki kcrash report
report of the same bug happening on Fedora 34 kde spin
Qt Version: 5.15.2
Frameworks Version: 5.85.0
Operating System: Linux 5.13.19-200.fc34.x86_64 x86_64
Windowing System: X11
Drkonqi Version: 5.22.5
Distribution: Fedora 34 (KDE Plasma)
tested on the new Fedora 35 pre-release and it works fine there, no bugs Operating System: Fedora Linux 35 KDE Plasma Version: 5.22.5 KDE Frameworks Version: 5.85.0 Qt Version: 5.15.2 Kernel Version: 5.14.6-300.fc35.x86_64 (64-bit) Graphics Platform: X11 dolphin-libs-21.08.0-2.fc35.x86_64 dolphin-plugins-21.08.0-1.fc35.x86_64 dolphin-21.08.0-2.fc35.x86_64 yes, it seems the problem at F34 is that the new build dont arrived yet: dolphin-21.08.0-2.fc34.x86_64 dolphin-libs-21.08.0-2.fc34.x86_64 dolphin-plugins-21.08.0-1.fc34.x86_64 *** Bug 442751 has been marked as a duplicate of this bug. *** *** Bug 442801 has been marked as a duplicate of this bug. *** *** Bug 443350 has been marked as a duplicate of this bug. *** It's probably fixed on Fedora 34 in 21.08.1 but in 21.08.0 it also crashes for me when terminal is hidden: ``` Application: Dolphin (dolphin), signal: Segmentation fault [KCrash Handler] #4 0x00007f3a686acd13 in QStackedLayout::widget(int) const () from /lib64/libQt5Widgets.so.5 #5 0x00007f3a38181a1d in Konsole::TabbedViewContainer::viewSplitterAt(int) () from /lib64/libkonsoleprivate.so.21 #6 0x00007f3a381848a6 in Konsole::TabbedViewContainer::currentTabViewCount() () from /lib64/libkonsoleprivate.so.21 #7 0x00007f3a3812c849 in Konsole::ViewManager::sessionFinished() () from /lib64/libkonsoleprivate.so.21 #8 0x00007f3a67b1c3a9 in void doActivate<false>(QObject*, int, void**) () from /lib64/libQt5Core.so.5 #9 0x00007f3a67b1c3a9 in void doActivate<false>(QObject*, int, void**) () from /lib64/libQt5Core.so.5 #10 0x00007f3a67a6fe73 in QProcess::finished(int, QProcess::ExitStatus) () from /lib64/libQt5Core.so.5 #11 0x00007f3a67a74433 in QProcessPrivate::_q_processDied() () from /lib64/libQt5Core.so.5 #12 0x00007f3a67a78102 in QProcessPrivate::waitForFinished(int) () from /lib64/libQt5Core.so.5 #13 0x00007f3a38196b3a in Konsole::Session::closeInNormalWay() () from /lib64/libkonsoleprivate.so.21 #14 0x00007f3a3818d13a in Konsole::Session::close() () from /lib64/libkonsoleprivate.so.21 #15 0x00007f3a67b1c3a9 in void doActivate<false>(QObject*, int, void**) () from /lib64/libQt5Core.so.5 #16 0x00007f3a67b173e3 in QObject::destroyed(QObject*) () from /lib64/libQt5Core.so.5 #17 0x00007f3a686c4813 in QWidget::~QWidget() () from /lib64/libQt5Widgets.so.5 #18 0x00007f3a381671dd in Konsole::TerminalDisplay::~TerminalDisplay() () from /lib64/libkonsoleprivate.so.21 #19 0x00007f3a67b1178a in QObjectPrivate::deleteChildren() () from /lib64/libQt5Core.so.5 #20 0x00007f3a686c4556 in QWidget::~QWidget() () from /lib64/libQt5Widgets.so.5 #21 0x00007f3a3810b6f5 in Konsole::ViewSplitter::~ViewSplitter() () from /lib64/libkonsoleprivate.so.21 #22 0x00007f3a67b1178a in QObjectPrivate::deleteChildren() () from /lib64/libQt5Core.so.5 #23 0x00007f3a686c4556 in QWidget::~QWidget() () from /lib64/libQt5Widgets.so.5 #24 0x00007f3a6884188d in QStackedWidget::~QStackedWidget() () from /lib64/libQt5Widgets.so.5 #25 0x00007f3a67b1178a in QObjectPrivate::deleteChildren() () from /lib64/libQt5Core.so.5 #26 0x00007f3a686c4556 in QWidget::~QWidget() () from /lib64/libQt5Widgets.so.5 #27 0x00007f3a381819dd in Konsole::TabbedViewContainer::~TabbedViewContainer() () from /lib64/libkonsoleprivate.so.21 #28 0x00007f3a697450b7 in KParts::Part::~Part() () from /lib64/libKF5Parts.so.5 #29 0x00007f3a3823811c in Konsole::Part::~Part() () from /usr/lib64/qt5/plugins/konsolepart.so #30 0x00007f3a67b1178a in QObjectPrivate::deleteChildren() () from /lib64/libQt5Core.so.5 #31 0x00007f3a686c4556 in QWidget::~QWidget() () from /lib64/libQt5Widgets.so.5 #32 0x0000558bb9fa21d6 in TerminalPanel::~TerminalPanel() () #33 0x00007f3a67b1178a in QObjectPrivate::deleteChildren() () from /lib64/libQt5Core.so.5 #34 0x00007f3a686c4556 in QWidget::~QWidget() () from /lib64/libQt5Widgets.so.5 #35 0x0000558bb9fcd3b1 in DolphinDockWidget::~DolphinDockWidget() () #36 0x00007f3a67b1178a in QObjectPrivate::deleteChildren() () from /lib64/libQt5Core.so.5 #37 0x00007f3a686c4556 in QWidget::~QWidget() () from /lib64/libQt5Widgets.so.5 #38 0x0000558bb9f705b1 in DolphinMainWindow::~DolphinMainWindow() () #39 0x0000558bb9f7062d in DolphinMainWindow::~DolphinMainWindow() () #40 0x00007f3a67b12d31 in QObject::event(QEvent*) () from /lib64/libQt5Core.so.5 #41 0x00007f3a6919cd2d in KXmlGuiWindow::event(QEvent*) () from /lib64/libKF5XmlGui.so.5 #42 0x00007f3a68686443 in QApplicationPrivate::notify_helper(QObject*, QEvent*) () from /lib64/libQt5Widgets.so.5 #43 0x00007f3a67ae8798 in QCoreApplication::notifyInternal2(QObject*, QEvent*) () from /lib64/libQt5Core.so.5 #44 0x00007f3a67aebd06 in QCoreApplicationPrivate::sendPostedEvents(QObject*, int, QThreadData*) () from /lib64/libQt5Core.so.5 #45 0x00007f3a67b3a0d7 in postEventSourceDispatch(_GSource*, int (*)(void*), void*) () from /lib64/libQt5Core.so.5 #46 0x00007f3a6581f4cf in g_main_context_dispatch () from /lib64/libglib-2.0.so.0 #47 0x00007f3a658734f8 in g_main_context_iterate.constprop () from /lib64/libglib-2.0.so.0 #48 0x00007f3a6581cc03 in g_main_context_iteration () from /lib64/libglib-2.0.so.0 #49 0x00007f3a67b39b78 in QEventDispatcherGlib::processEvents(QFlags<QEventLoop::ProcessEventsFlag>) () from /lib64/libQt5Core.so.5 #50 0x00007f3a67ae71a2 in QEventLoop::exec(QFlags<QEventLoop::ProcessEventsFlag>) () from /lib64/libQt5Core.so.5 #51 0x00007f3a67aef6e4 in QCoreApplication::exec() () from /lib64/libQt5Core.so.5 #52 0x0000558bb9f6d64f in main () [Inferior 1 (process 23153) detached] ``` Created attachment 142650 [details]
New crash information added by DrKonqi
kdevelop (5.6.2) using Qt 5.15.2
- What I was doing when the application crashed:
I was closing the KDEvelop application regularly over its menu point. Its reproducable every single time.
I understand, this was closed some time ago, but it seems as if there are some remnants somehere.
-- Backtrace (Reduced):
#4 0x00007f4575d46d13 in QStackedLayout::widget(int) const () from /lib64/libQt5Widgets.so.5
#5 0x00007f44bb04ca1d in Konsole::TabbedViewContainer::viewSplitterAt(int) () from /lib64/libkonsoleprivate.so.21
#6 0x00007f44bb04f8a6 in Konsole::TabbedViewContainer::currentTabViewCount() () from /lib64/libkonsoleprivate.so.21
#7 0x00007f44baff7849 in Konsole::ViewManager::sessionFinished() () from /lib64/libkonsoleprivate.so.21
#8 0x00007f457509b3a9 in void doActivate<false>(QObject*, int, void**) () from /lib64/libQt5Core.so.5
|