Bug 440980

Summary: "Files" view no longer loads
Product: [Applications] Elisa Reporter: Ilya Bizyaev <bizyaev>
Component: generalAssignee: Matthieu Gallien <matthieu_gallien>
Status: RESOLVED FIXED    
Severity: grave CC: bart, empyreal, liubomirwm, nate
Priority: VHI Keywords: regression
Version First Reported In: 21.08.0   
Target Milestone: ---   
Platform: openSUSE   
OS: Linux   
Latest Commit: https://invent.kde.org/multimedia/elisa/-/commit/618cf9b589ef9dd58e3ec3dd7450a80f10e118f8 Version Fixed/Implemented In: 21.08.1
Sentry Crash Report:

Description Ilya Bizyaev 2021-08-14 19:04:58 UTC 
SUMMARY
After the update to 21.08, when I open Elisa and click "Files" in the left sidebar, I get a spinning indicator in the main view, and it spins forever.


SOFTWARE/OS VERSIONS
Operating System: openSUSE Leap 15.3
KDE Plasma Version: 5.22.4
KDE Frameworks Version: 5.84.0
Qt Version: 5.15.2
Comment 1 Nate Graham 2021-08-16 17:19:29 UTC 
Oh dear.
Comment 2 Nate Graham 2021-08-16 17:37:17 UTC 
It was broken by this:

commit ab48bc4f78902e02f9f1c59e5dba3e90452efba9
Author: Matthieu Gallien <matthieu_gallien@yahoo.fr>
Date:   Sat Jun 26 17:25:58 2021 +0200

    make KIO optional on Android and required everywhere else

 CMakeLists.txt           | 7 ++++++-
 README.packagers         | 2 +-
 src/elisaapplication.cpp | 7 +++++++
 src/viewmanager.cpp      | 9 +++++++++
 4 files changed, 23 insertions(+), 2 deletions(-)
Comment 3 Nate Graham 2021-08-16 17:42:30 UTC 
The problem appears to be that the KF5KIO_FOUND CMake macro is not visible in viewmanager.cpp, so it always evaluates to false, which means we get no files view populated. This is also buggy; the view should also disappear from the sidebar in this case, but it does not. Instead it just sits there taunting you, daring you to click on it, only to dash your hopes by not loading anything. If it disappeared from the sidebar too, probably someone would have noticed this before the release.
Comment 4 Nate Graham 2021-08-24 15:00:47 UTC 
*** Bug 441450 has been marked as a duplicate of this bug. ***
Comment 5 empyreal 2021-08-25 09:47:16 UTC 
viewslistdata.cpp
compare 21.04 file with master

Problem in these lines:
#if defined KF5KIO_FOUND && KF5KIO_FOUND
#endif
#if defined KF5KIO_FOUND && KF5KIO_FOUND
#else
        newModel = nullptr;
        proxyModel = nullptr;
#endif

remove or comment them and Files Window will work
Comment 6 Nate Graham 2021-08-25 14:49:08 UTC 
Fixed by Bart De Vries with https://invent.kde.org/multimedia/elisa/-/commit/618cf9b589ef9dd58e3ec3dd7450a80f10e118f8 in Elisa 21.08.1!
Comment 7 Nate Graham 2021-09-02 18:18:03 UTC 
*** Bug 441911 has been marked as a duplicate of this bug. ***