Bug 440867

Summary:	kdenlive 21.08.0 (packager tars) fails to build with new glibc 2.34
Product:	[Applications] kdenlive	Reporter:	Rik Mills <rikmills>
Component:	Setup & Installation	Assignee:	Vincent PINON <vpinon>
Status:	RESOLVED WORKSFORME
Severity:	normal	CC:	fritzibaby
Priority:	NOR	Flags:	fritzibaby: Brainstorm+
Version First Reported In:	unspecified
Target Milestone:	---
Platform:	Other
OS:	Linux
Latest Commit:		Version Fixed/Implemented In:
Sentry Crash Report:
Attachments:	build log

Description Rik Mills 2021-08-11 11:20:11 UTC

Created attachment 140654 [details]
build log

SUMMARY

kdenlive (tests) fail to build with new glibc 2.34

STEPS TO REPRODUCE
1. Build with glibc 2.34

Builds: https://launchpad.net/~ci-train-ppa-service/+archive/ubuntu/3997/+sourcepub/12642664/+listing-archive-extra

amd64 build log is attached

failing section copied below:

In file included from /usr/include/signal.h:328,
                 from /<<PKGBUILDDIR>>/tests/catch.hpp:5903,
                 from /<<PKGBUILDDIR>>/tests/TestMain.cpp:2:
/<<PKGBUILDDIR>>/tests/catch.hpp:8525:58: error: call to non-‘constexpr’ function ‘long int sysconf(int)’
 8525 |     constexpr static std::size_t sigStackSize = 32768 >= MINSIGSTKSZ ? 32768 : MINSIGSTKSZ;
      |                                                          ^~~~~~~~~~~
In file included from /usr/include/x86_64-linux-gnu/bits/sigstksz.h:24,
                 from /usr/include/signal.h:328,
                 from /<<PKGBUILDDIR>>/tests/catch.hpp:5903,
                 from /<<PKGBUILDDIR>>/tests/TestMain.cpp:2:
/usr/include/unistd.h:641:17: note: ‘long int sysconf(int)’ declared here
  641 | extern long int sysconf (int __name) __THROW;
      |                 ^~~~~~~
In file included from /<<PKGBUILDDIR>>/tests/TestMain.cpp:2:
/<<PKGBUILDDIR>>/tests/catch.hpp:8584:45: error: size of array ‘altStackMem’ is not an integral constant-expression
 8584 |     char FatalConditionHandler::altStackMem[sigStackSize] = {};
      |                                             ^~~~~~~~~~~~

Comment 1 Jean-Baptiste Mardelle 2021-08-12 19:44:30 UTC

Git commit d6462a990fe42148079a570b3be4bc960b3548a5 by Jean-Baptiste Mardelle.
Committed on 12/08/2021 at 19:44.
Pushed by mardelle into branch 'master'.

Update catch.hpp.

M  +5834 -2561 tests/catch.hpp

https://invent.kde.org/multimedia/kdenlive/commit/d6462a990fe42148079a570b3be4bc960b3548a5

Comment 2 emohr 2021-08-15 12:05:38 UTC

@Rik Could you test if the fix solves the problem?

Comment 3 Bug Janitor Service 2021-08-30 04:36:24 UTC

Dear Bug Submitter,

This bug has been in NEEDSINFO status with no change for at least
15 days. Please provide the requested information as soon as
possible and set the bug status as REPORTED. Due to regular bug
tracker maintenance, if the bug is still in NEEDSINFO status with
no change in 30 days the bug will be closed as RESOLVED > WORKSFORME
due to lack of needed information.

For more information about our bug triaging procedures please read the
wiki located here:
https://community.kde.org/Guidelines_and_HOWTOs/Bug_triaging

If you have already provided the requested information, please
mark the bug as REPORTED so that the KDE team knows that the bug is
ready to be confirmed.

Thank you for helping us make KDE software even better for everyone!

Comment 4 Bug Janitor Service 2021-09-14 04:36:12 UTC

This bug has been in NEEDSINFO status with no change for at least
30 days. The bug is now closed as RESOLVED > WORKSFORME
due to lack of needed information.

For more information about our bug triaging procedures please read the
wiki located here:
https://community.kde.org/Guidelines_and_HOWTOs/Bug_triaging

Thank you for helping us make KDE software even better for everyone!

Comment 5 Jean-Baptiste Mardelle 2021-11-01 13:46:54 UTC

Git commit adc86cfe0f2df232106530e5ceef576a93a856b4 by Jean-Baptiste Mardelle.
Committed on 01/11/2021 at 13:46.
Pushed by mardelle into branch 'cherry-pick-d6462a99'.

Update catch.hpp.


(cherry picked from commit d6462a990fe42148079a570b3be4bc960b3548a5)

M  +5834 -2561 tests/catch.hpp

https://invent.kde.org/multimedia/kdenlive/commit/adc86cfe0f2df232106530e5ceef576a93a856b4

Comment 6 Bug Janitor Service 2021-11-01 13:47:19 UTC

A possibly relevant merge request was started @ https://invent.kde.org/multimedia/kdenlive/-/merge_requests/256