Bug 440649

Summary:	Kickoff RTL problems on Plasma 5.22.80
Product:	[Plasma] plasmashell	Reporter:	Omeritzics <omeritzicschwartz>
Component:	Application Launcher (Kickoff) widget	Assignee:	David Edmundson <kde>
Status:	RESOLVED FIXED
Severity:	normal	CC:	mikel5764, nate, noahadvs, omeritzicschwartz, plasma-bugs-null, sh.yaron
Priority:	NOR	Keywords:	rtl
Version First Reported In:	master
Target Milestone:	1.0
Platform:	Other
OS:	Linux
Latest Commit:		Version Fixed In:
Sentry Crash Report:
Attachments:	Kickoff "Applications" tab in RTL Kickoff "Aplications" tab in LTR Kickoff "Places" tab in RTL mode Kickoff on Kubuntu 21.10 (Plasma 5.23.3)

Description Omeritzics 2021-08-05 21:35:19 UTC

SUMMARY
Kickoff is compact, and the icons are at the edge of the screen in RTL mode.

STEPS TO REPRODUCE
1. Use a RTL language (Hebrew, Arabic, Persian, etc.)
2. Open Kickoff menu
*3. Compare between the LTR and the RTL versions.

OBSERVED RESULT
Kickoff is compact, and the icons are at the edge of the screen in RTL mode.

EXPECTED RESULT
Kickoff should not be compact, and the icons should not be at the edge of the screen in RTL mode.

SOFTWARE/OS VERSIONS
Operating System: KDE neon Unstable Edition
KDE Plasma Version: 5.22.80
KDE Frameworks Version: 5.85.0
Qt Version: 5.15.3
Graphics Platform: X11

ADDITIONAL INFORMATION
The "Leave" icon may should be flipped, because the different writing directions of RTL languages.

Comment 1 Omeritzics 2021-08-05 21:48:58 UTC

Created attachment 140552 [details]
Kickoff "Applications" tab in RTL

Comment 2 Omeritzics 2021-08-05 21:49:21 UTC

Created attachment 140553 [details]
Kickoff "Aplications" tab in LTR

Comment 3 Nate Graham 2021-08-06 17:12:47 UTC

The button not being reversed is because we're using the `system-log-out` icon which has no RTL version; that would need to be created first.

Cannot reproduce the right margin issue and sidebar squeezing issue with doing `plasmashell --reverse` with English. However it may be different with an actual RTL language.

Comment 4 Noah Davis 2021-08-07 16:10:46 UTC

(In reply to Nate Graham from comment #3)
> The button not being reversed is because we're using the `system-log-out`
> icon which has no RTL version; that would need to be created first.
> 
> Cannot reproduce the right margin issue and sidebar squeezing issue with
> doing `plasmashell --reverse` with English. However it may be different with
> an actual RTL language.

Yes, I'm also having trouble reproducing it in reverse mode. There is a know issue with left/right margins in ListViews, but it doesn't cause the content to be clipped off and I have no idea why the issue is there. The code is correct and identical to the code for the GridViews (which do work correctly). Too bad we don't have any Plasma devs (that I know of) who use a real RTL locale. It's also not easy for me to install just the locales I need to test with on openSUSE (if I could read them in the first place; I only know English).

Comment 5 Omeritzics 2021-11-28 15:47:26 UTC

This bug does not exist when "All applications" tab is untranslated. Also, the Hebrew translation, "כל היישומים" contains 5 less characters than the original string.

Comment 6 Noah Davis 2021-11-28 17:20:56 UTC

(In reply to Omeritzics from comment #5)
> This bug does not exist when "All applications" tab is untranslated. Also,
> the Hebrew translation, "כל היישומים" contains 5 less characters than the
> original string.

Thanks for the additional testing. Any extra info you can provide helps.

Comment 7 Omeritzics 2021-11-29 14:41:59 UTC

Created attachment 144065 [details]
Kickoff "Places" tab in RTL mode

The Kickoff "Places" tab was not affected by this bug.

Comment 8 Omeritzics 2021-11-30 15:30:43 UTC

This bug seems to be fixed on Kubuntu 21.10, containing Plasma 5.23.3, but not on KDE neon.

Comment 9 Omeritzics 2021-11-30 15:31:27 UTC

Created attachment 144086 [details]
Kickoff on Kubuntu 21.10 (Plasma 5.23.3)

Comment 10 Nate Graham 2021-11-30 17:28:12 UTC

Yes, this was fixed recently in a frameworks update.