Bug 440538

Summary:	Krita 4.4.5 identifies itself as version 4.5.4 on Windows platform
Product:	[Applications] krita	Reporter:	Christian Finnberg <christian>
Component:	* Unknown	Assignee:	Alvin Wong <alvin>
Status:	RESOLVED INTENTIONAL
Severity:	normal	CC:	alvin
Priority:	NOR
Version First Reported In:	4.4.5
Target Milestone:	---
Platform:	Microsoft Windows
OS:	Microsoft Windows
Latest Commit:		Version Fixed In:
Sentry Crash Report:

Description Christian Finnberg 2021-08-03 05:00:47 UTC

SUMMARY

Krita 4.4.5 identifies itself as version 4.5.4 on Windows platform.


STEPS TO REPRODUCE
Install Krita and check the version from somewhere (control panel, Settings, registry,...)

OBSERVED RESULT
Krita is marked as version 4.5.4

EXPECTED RESULT
Krita should be marked as version 4.4.5

SOFTWARE/OS VERSIONS
Windows: Windows 10 21H1

Comment 1 Alvin Wong 2021-08-03 07:33:45 UTC

Thanks for reporting. There was a manual editing error that didn't get caught: https://invent.kde.org/graphics/krita/-/blob/v4.4.5/CMakeLists.txt#L82

Technically, that is only aesthetic and doesn't affect the functionality, so we won't be making a release just to fix this issue. It's technically not "intentional", but since it is not going to be fixed I will mark it as such.

Comment 2 Christian Finnberg 2021-08-03 07:51:20 UTC

Yes, I know this is a low level problem. The only matter that I thought it may affect is in the next release. Does the installer checks the version of Krita being updated? For example if the next release is 4.4.6, can the installer think that it is older than the installed version (as it is now marked as 4.5.4)? And can that affect in any way?

Maybe there is no problem at all, but just in case :)

Comment 3 Alvin Wong 2021-08-03 08:15:51 UTC

Git commit c83af1396825f2d38daa14b407a98ca4bf44e4d2 by Alvin Wong.
Committed on 03/08/2021 at 08:15.
Pushed by alvinwong into branch 'master'.

NSIS: Add handling for incorrect version with 4.4.5.0

M  +4    -0    packaging/windows/installer/installer_krita.nsi

https://invent.kde.org/graphics/krita/commit/c83af1396825f2d38daa14b407a98ca4bf44e4d2

Comment 4 Alvin Wong 2021-08-03 08:17:51 UTC

Git commit f4e65cf8698428cab11cb657d5ce4cc07a469f37 by Alvin Wong.
Committed on 03/08/2021 at 08:17.
Pushed by alvinwong into branch 'krita/4.3'.

NSIS: Add handling for incorrect version with 4.4.5.0


(cherry picked from commit c83af1396825f2d38daa14b407a98ca4bf44e4d2)

M  +4    -0    packaging/windows/installer/installer_krita.nsi

https://invent.kde.org/graphics/krita/commit/f4e65cf8698428cab11cb657d5ce4cc07a469f37

Comment 5 Alvin Wong 2021-08-03 08:19:09 UTC

Thanks, it has been taken care of (I hope).