Bug 440203

Summary:	docutils>=0.17 changed html output which breaks some of the manual's css styling
Product:	[Applications] krita	Reporter:	Alvin Wong <alvin>
Component:	Documentation	Assignee:	Krita Bugs <krita-bugs-null>
Status:	RESOLVED FIXED
Severity:	task
Priority:	NOR
Version First Reported In:	nightly build (please specify the git hash!)
Target Milestone:	---
Platform:	Other
OS:	Other
Latest Commit:	https://invent.kde.org/documentation/docs-krita-org/commit/6a98b9d39ff65212cd91d91738acaa2e3aca5260	Version Fixed/Implemented In:
Sentry Crash Report:

Description Alvin Wong 2021-07-23 16:12:15 UTC

docutils 0.17 changelog: https://docutils.sourceforge.io/HISTORY.html#release-0-17-2021-04-03

(See changes for `docutils/writers/html5_polyglot/__init__.py`)

I noticed some issues with the use of `.section` selector (docutils now output <section> instead of <div class="section">), most noticeable is the broken indentation of unordered lists. Not sure if there are other problems.

Current binary-factory appears to be safe... making this bug as a reminder for now.

Comment 1 Alvin Wong 2021-07-23 16:21:20 UTC

Related upstream issues:

- https://github.com/readthedocs/sphinx_rtd_theme/pull/1113
- https://github.com/readthedocs/sphinx_rtd_theme/issues/1115

Looks like `sphinx_rtd_theme` has been requiring `docutils<0.17` and the binary-factory docker image installs it, so that's why it is safe. We shall monitor the upstream issue for any news.

Comment 2 Alvin Wong 2021-08-13 08:07:08 UTC

Upstream updated the theme, we shall look into backporting the changes:
https://github.com/readthedocs/sphinx_rtd_theme/pull/1185

Comment 3 Alvin Wong 2021-08-24 10:09:27 UTC

Git commit c2e98c6933c0f0c17366ac21f81fb956fd2da685 by Alvin Wong.
Committed on 24/08/2021 at 10:07.
Pushed by alvinwong into branch 'master'.

Port theme CSS to support page generated with docutils>=0.17

Partially backported the changes from:

- https://github.com/readthedocs/sphinx_rtd_theme/pull/1185
- https://github.com/readthedocs/sphinx_rtd_theme/pull/1199

M  +67   -9    theme/static/css/theme.css

https://invent.kde.org/documentation/docs-krita-org/commit/c2e98c6933c0f0c17366ac21f81fb956fd2da685

Comment 4 Alvin Wong 2021-08-24 10:09:59 UTC

Git commit 6a98b9d39ff65212cd91d91738acaa2e3aca5260 by Alvin Wong.
Committed on 24/08/2021 at 10:09.
Pushed by alvinwong into branch 'krita/5.0'.

Port theme CSS to support page generated with docutils>=0.17

Partially backported the changes from:

- https://github.com/readthedocs/sphinx_rtd_theme/pull/1185
- https://github.com/readthedocs/sphinx_rtd_theme/pull/1199


(cherry picked from commit c2e98c6933c0f0c17366ac21f81fb956fd2da685)

M  +67   -9    theme/static/css/theme.css

https://invent.kde.org/documentation/docs-krita-org/commit/6a98b9d39ff65212cd91d91738acaa2e3aca5260