Summary: | No support for "dc cvac" and "dc cvap" on Arm64 | ||
---|---|---|---|
Product: | [Developer tools] valgrind | Reporter: | kevinz <kevin.zhao> |
Component: | memcheck | Assignee: | Julian Seward <jseward> |
Status: | RESOLVED FIXED | ||
Severity: | normal | CC: | assad.hashmi, mark, pjfloyd |
Priority: | NOR | ||
Version: | unspecified | ||
Target Milestone: | --- | ||
Platform: | Other | ||
OS: | Other | ||
Latest Commit: | Version Fixed In: | ||
Attachments: | Patch to enable support for dc cvap and dc cvac |
Description
kevinz
2021-07-21 03:23:48 UTC
Try copying the scheme used for 'dc cvau' in guest_arm64_toIR.c. That might just work for the cases you care about too. Hi Julian, Thanks, I will work on this Created attachment 140268 [details]
Patch to enable support for dc cvap and dc cvac
Tested locally on Arm v8.2 machines, works well @Julian, Could you point me how to submit patches to Valgrind? Thanks! (In reply to kevinz from comment #5) > Could you point me how to submit patches to Valgrind? > Thanks! Best is to attach a patch to this bug. Yes, already attached. Please help to check and review. Thanks a lot! ping @Julian, Could you help to take a look at the attached patch? Thanks! commit 40505e5056a7e434e291526d6662943e31274fc1 (HEAD -> master, origin/master, origin/HEAD) Author: Kevin Zhao <kevin.zhao@linaro.org> Date: Thu Jul 22 16:00:21 2021 +0800 arm64 front end: add support for 'dc cvac', 'dc cvap', handling it the same as 'dc cvau'. patch modified to process DBP component of ID_AA64ISAR1_EL1 Signed-off-by: Kevin Zhao <kevin.zhao@linaro.org> |