Bug 440015

Summary:	Metadata Template insists on putting in a country name.
Product:	[Applications] digikam	Reporter:	jm7 <jm7>
Component:	Metadata-Template	Assignee:	Digikam Developers <digikam-bugs-null>
Status:	RESOLVED FIXED
Severity:	normal	CC:	metzpinguin
Priority:	NOR
Version:	7.3.0
Target Milestone:	---
Platform:	Microsoft Windows
OS:	Microsoft Windows
Latest Commit:	https://invent.kde.org/graphics/digikam/commit/1c95ac9d91528faba8796d417afaaff7fc8b543b	Version Fixed In:	7.4.0
Sentry Crash Report:

Description jm7@acm.org 2021-07-18 19:54:29 UTC

SUMMARY
Metadata Template insists on putting in a country name.


STEPS TO REPRODUCE
1. open the metadata template editor
2. create a template without touching the location tab.
3. save the template.
4. Use the template.  It will default to "Aruba".
4. reopen the template and navigate to the location tab.  The location will say "Aruba".

I have tried setting this to "unknown" with the same result.  

OBSERVED RESULT
The default location country is not blank, it is "Aruba".

EXPECTED RESULT

Default template country should be blank and should not change the country in the metadata if blank.

Location information should be coming from reverse geocoding in any case.

SOFTWARE/OS VERSIONS
Windows: 10
macOS: 
Linux/KDE Plasma: 
(available in About System)
KDE Plasma Version: 
KDE Frameworks Version: 
Qt Version: 

ADDITIONAL INFORMATION
This behavior is made worse by the companion bug where the data provided by the template is not editable.

Comment 1 Maik Qualmann 2021-07-19 05:54:21 UTC

I cannot reproduce a problem. If the country field should remain empty, the country must be set to "Unknown". Your mistake will be that you do not apply the changes in the template editor when you have edited a template. You either have to add it as a new one with the "Add ..." button or overwrite it with "Replace ...". A simple "Ok" in the dialog does not apply your changes.

Maik

Comment 2 jm7@acm.org 2021-07-19 21:22:03 UTC

There is an error in the UI that was causing confusion.  There is an OK button and a Cancel button.  If there are never changes applied by the OK button, but instead it is some process in the dialog that needs to be completed, there should not be either an OK button or a Cancel button, but instead there should be a CLOSE button.

In any case, the default should not be "Aruba" when setting up a template, it should be unknown.  Especially if the tab has not been selected.

This also goes hand in hand with the templates overwriting things they really shouldn't.  The templates as they stand have destroyed the metadata on about 100 images of mine now.  

I know NOT to use them and use exifer instead as exifer is better behaved about overwriting more selectively.

Comment 3 Maik Qualmann 2021-07-21 18:41:54 UTC

Regardless of the other problems with the templates, the default country for a new template is definitely "Unknown".

Maik

Comment 4 Maik Qualmann 2021-07-21 19:24:13 UTC

Git commit 1c95ac9d91528faba8796d417afaaff7fc8b543b by Maik Qualmann.
Committed on 21/07/2021 at 19:22.
Pushed by mqualmann into branch 'master'.

apply current template with the dialog OK button
FIXED-IN: 7.4.0

M  +1    -1    NEWS
M  +16   -0    core/utilities/setup/setuptemplate.cpp

https://invent.kde.org/graphics/digikam/commit/1c95ac9d91528faba8796d417afaaff7fc8b543b