Summary: | Updating filters make them not working anymore | ||
---|---|---|---|
Product: | [Applications] krita | Reporter: | Patrice <webmaster555> |
Component: | G'Mic for Krita | Assignee: | amyspark <amy> |
Status: | RESOLVED FIXED | ||
Severity: | grave | CC: | ahab.greybeard, alvin, amy |
Priority: | NOR | ||
Version: | 4.4.5 | ||
Target Milestone: | --- | ||
Platform: | Appimage | ||
OS: | Linux | ||
Latest Commit: | https://invent.kde.org/graphics/krita/commit/39de844d68165affccb92e8d053143c3feccbf38 | Version Fixed In: | |
Attachments: | Screenshot to reproduce the bug |
Description
Patrice
2021-07-18 03:18:41 UTC
I can confirm that this is a problem with the July 18 5.0.0-prealpha (git c24193f) appimage. A way for the end user to be able to fix this and not always having the need to report as a bug, would be that in Krita 5 to give back the choice of changing the G'MIC integration the end user would like to use, exactly the same way like it is done in Krita 4.x where we can chose our G'MIC integration. I did made a post on Krita.org > https://krita-artists.org/t/bug-ask-for-regression-krita-5-embedded-gmic-path/26367 It would seem that inevitably we have to completely disable the filter update function, because newer G'MIC filter definitions often depend on updated version of G'MIC, as long as gmic-qt is included in the form of a plugin... (In reply to Alvin Wong from comment #3) > It would seem that inevitably we have to completely disable the filter > update function, because newer G'MIC filter definitions often depend on > updated version of G'MIC, as long as gmic-qt is included in the form of a > plugin... On Krita 5 Limiting/restraining the end user is NOT a solution. Giving back the end user the ability to update/upgrade or chose its G'MIC integration like in any Krita 4.x.x appimage or whatever type, is the certainly the way to go > https://krita-artists.org/uploads/default/original/3X/8/f/8f4c2d0a82d7d7f90f94413e6f84f6f13fe8aa0f.png In Krita 5 they just removed this possibility in the preferences > https://krita-artists.org/uploads/default/original/3X/c/3/c320b2d2c6bee8e9ba6d1a2f70e7c6391426de25.png thus we are stuck with a deprecated G'MIC Git commit 39de844d68165affccb92e8d053143c3feccbf38 by Halla Rempt, on behalf of L. E. Segovia. Committed on 12/08/2021 at 13:30. Pushed by rempt into branch 'master'. GMic: update to 2.9.8 This update rolls all existing updates into a single patch and integrates the following new changes: - Update the plugin to the new GMic-Qt API (while also ignoring it, because to implement the plugin architecture it needs to run within our QCoreApplication) - Add support for compiling under MSVC (this includes support for FFTW3, LTO, Control Flow Guard, the MinGW stack size increase, and a fix to the CreateThread callback signature in GMic) - Add support for Android (future proof) - Make FFTW3 a truly optional library (the GMic-Qt toggle is a dud at present, this patch fixes it) - Increase the minimum on-launch update timeout to 60s (as soon as you have some ping, the update will spuriously fail) - Restore compatibility with stock GMic-Qt settings (previously, due to an oversight on my part, it wrote them willy-nilly in the Krita namespace) It also adds new defines that allow to disable the following: - Dark Theme mode - Internet access by default - GMic-Qt's own i18n management, thus respecting the host app's language - All updates altogether M +1 -1 3rdparty_plugins/CMakeLists.txt A +503 -0 3rdparty_plugins/ext_gmic/0001-Add-Krita-native-plugin.patch D +0 -516 3rdparty_plugins/ext_gmic/0001-First-working-version-of-the-GMic-Qt-Krita-native-pl.patch A +289 -0 3rdparty_plugins/ext_gmic/0002-Add-support-for-MSVC.patch D +0 -290 3rdparty_plugins/ext_gmic/0002-Remove-shared-segment-infrastructure.patch A +179 -0 3rdparty_plugins/ext_gmic/0003-Add-Android-support.patch D +0 -170 3rdparty_plugins/ext_gmic/0003-Refactor-into-a-completely-Krita-native-plugin.patch D +0 -33 3rdparty_plugins/ext_gmic/0004-Enable-all-input-modes-for-Krita-plugin.patch A +41 -0 3rdparty_plugins/ext_gmic/0004-Make-FFTW3-truly-optional.patch R +25 -25 3rdparty_plugins/ext_gmic/0005-Disable-GMic-Qt-s-own-theming-for-Krita.patch [from: 3rdparty_plugins/ext_gmic/0007-Disable-GMic-Qt-s-own-theming-for-Krita.patch - 065% similarity] D +0 -82 3rdparty_plugins/ext_gmic/0005-Update-function-signatures-to-2.9.6.patch R +32 -32 3rdparty_plugins/ext_gmic/0006-Add-flag-to-disable-internet-access-by-default.patch [from: 3rdparty_plugins/ext_gmic/0008-Add-flag-to-disable-internet-access-by-default.patch - 051% similarity] D +0 -186 3rdparty_plugins/ext_gmic/0006-Add-support-for-MSVC.patch R +8 -8 3rdparty_plugins/ext_gmic/0007-Increase-on-launch-update-timeout-to-60s.patch [from: 3rdparty_plugins/ext_gmic/0009-Increase-on-launch-update-timeout-to-60s.patch - 055% similarity] A +66 -0 3rdparty_plugins/ext_gmic/0008-Enable-respecting-host-application-language.patch A +186 -0 3rdparty_plugins/ext_gmic/0009-Respect-settings-location-for-hosted-builds.patch A +132 -0 3rdparty_plugins/ext_gmic/0010-Disable-Internet-updates-in-Krita.patch M +15 -34 3rdparty_plugins/ext_gmic/CMakeLists.txt M +14 -19 plugins/extensions/qmic/gmic.h M +40 -48 plugins/extensions/qmic/kis_input_output_mapper.cpp M +5 -5 plugins/extensions/qmic/kis_qmic_interface.cpp https://invent.kde.org/graphics/krita/commit/39de844d68165affccb92e8d053143c3feccbf38 |