Bug 439848

Summary:	Request : prevent showing/hiding guides to cancel/commit transform mode
Product:	[Applications] krita	Reporter:	stephen <tgdev001>
Component:	Tools/Transform	Assignee:	Dmitry Kazakov <dimula73>
Status:	RESOLVED FIXED
Severity:	normal	CC:	dimula73
Priority:	NOR
Version First Reported In:	4.4.5
Target Milestone:	---
Platform:	unspecified
OS:	All
Latest Commit:	https://invent.kde.org/graphics/krita/commit/c3c97d104a6c423520dc5719594a5744d92cfc0c	Version Fixed In:
Sentry Crash Report:

Description stephen 2021-07-14 18:59:29 UTC

SUMMARY
Other than snap, hiding/showing guides cancels/commits an
active transform mode. This is not a bug but a situation
which is in my opinion, counter productive. 
I hope you can do something about it.

STEPS TO REPRODUCE
1. Have some pixels painted on a layer.
2. Go in transform mode, I press "CTRL + T" on my side for that.
3. While in transform mode, toggle showing guides on/off

OBSERVED RESULT
Toggling the guide appearance on the canvas commits the active transform mode, and you exit it
without wanting that.
Like if it's necessary to exit transform mode to show/hide canvas guides.

EXPECTED RESULT
The transform mode is supposed to stay active, whether the guides display is toggled on or off. show_guides() != commit_transform().

SOFTWARE/OS VERSIONS
Windows 10 1909 

But it's probably applicable to all other OSs as well.

Comment 1 Dmitry Kazakov 2021-07-17 07:44:22 UTC

Git commit c3c97d104a6c423520dc5719594a5744d92cfc0c by Dmitry Kazakov.
Committed on 17/07/2021 at 07:25.
Pushed by dkazakov into branch 'master'.

Properly fix cancellation of the transform tool when changing guides config

We can easily postpone the synchronization of the decorations layer. The
layer itself doesn't store any decorations data. Instead, it just links
to the document itself. So we can update this link whatever time we like
later.
Related: bug 439549

M  +1    -0    libs/ui/KisDocument.cpp

https://invent.kde.org/graphics/krita/commit/c3c97d104a6c423520dc5719594a5744d92cfc0c