Bug 439703

Summary:	Doesn't show a brush tip from a disabled bundle
Product:	[Applications] krita	Reporter:	Tiar <tamtamy.tymona>
Component:	Resource Management	Assignee:	Krita Bugs <krita-bugs-null>
Status:	RESOLVED INTENTIONAL
Severity:	normal	CC:	halla
Priority:	NOR	Keywords:	regression, release_blocker
Version:	git master (please specify the git hash!)
Target Milestone:	---
Platform:	Mint (Ubuntu based)
OS:	Linux
Latest Commit:		Version Fixed In:
Sentry Crash Report:

Description Tiar 2021-07-09 22:36:53 UTC

SUMMARY
Link: https://krita-artists.org/t/resource-bugs-in-krita-5/23235/60


STEPS TO REPRODUCE
1. Make a bundle or a preset using an older brush tip from Krita 3 bundle
2. Try to import the bundle or the preset with the brush tip on default Krita 5
3. It doesn't show the brush tip, because:
- the bundle Krita 3 is deactivated
- the newly imported brush tip is deactivated as well because there is already a resource in the database with the same md5.

OBSERVED RESULT
^ as above.

EXPECTED RESULT
Should show the brush tip one way or another.

SOFTWARE/OS VERSIONS
git hash: 13f04ca236

Comment 1 Halla Rempt 2021-07-27 09:36:55 UTC

That reasoning doesn't work, because brush tips are retrieved using the KisAllResourcesModel, which does not check whether the storage is active. And when this bug report was created, brush tips were not located using the md5sum, but the filename of the brush tip.

The md5sum reasoning also doesn't seem logical to me; if the md5sum is the same, the resource contains the same bytes, but in any case, if the brush tips are in separate storages, there is no clash.

Comment 2 Tiar 2021-08-06 17:56:32 UTC

Alright, the problem is that there is only one brush tip and it is in the Krita 3 bundle. The brush preset works correctly, but the brush tip is not shown in the Predefined Brush Tip area because the bundle is disabled (so it's filtered out). 

I was wrong, thinking that preset comes from a bundle; it is actually in the local resources.

Maybe Krita 4 just added those brush tips manually to the view, or something?

Maybe we could leave it to Krita 5.1, though.

Comment 3 Halla Rempt 2021-08-10 07:38:55 UTC

No, the brush tip shouldn't be shown: the bundle is deactivated, after all. But it is used correctly, so the preset isn't broken. This works as designed.