Bug 439618

Summary: kcm_keys 'Import Shortcut Scheme' OverlaySheet has incorrect left margin
Product: [Frameworks and Libraries] frameworks-kirigami Reporter: Gabriel <gabriel>
Component: generalAssignee: Marco Martin <notmart>
Status: RESOLVED FIXED    
Severity: minor CC: kde, nate
Priority: NOR    
Version First Reported In: Master   
Target Milestone: Not decided   
Platform: Other   
OS: Linux   
Latest Commit: Version Fixed/Implemented In:
Sentry Crash Report:
Attachments: Screenshot of the window

Description Gabriel 2021-07-07 21:50:41 UTC
Created attachment 139931 [details]
Screenshot of the window

SUMMARY
The modal window that appears when clicking the "Import Scheme..." button in the shortcuts settings looks a bit off. In the title bar the text size is different and it seems like it doesn't adapt to the changes made in window decorations. For example, changing to Plastik has no effect on its appearance. The content area however seems fine, though it could benefit from some side margins.

STEPS TO REPRODUCE
1. Open System settings
2. Navigate to Shortcuts
3. Click the button "Import Scheme..."

OBSERVED RESULT
The appearing modal window has a title bar that doesn't adapt to basic theming and a content area that lacks side margins.

EXPECTED RESULT
The modal window looks consistent with the chosen theme settings and with some margins on each side of the content.

SOFTWARE/OS VERSIONS
KDE Plasma Version: 5.22.2
KDE Frameworks Version: 5.84.0
Qt Version: 5.15.3
Comment 1 David Redondo 2021-07-08 06:44:03 UTC
Hmm I don't remember it being that small, but you're right could use some padding. I wonder if something changed in OverlaySheet compared to how it was originally.
Comment 2 Nate Graham 2021-07-30 17:52:47 UTC
Indeed, the automatic width calculation seems to be off here. Moving to Kirigami.
Comment 3 Gabriel 2022-03-15 23:49:20 UTC
No longer a problem in Frameworks 5.91! I tried to find the commit that fixed it, but couldn't from the quick search I did.
To whoever fixed it: Thank you!