| Summary: | Plasma-5.18.7.1, screen lock: textbox/loginbox not activated by keyboard | ||
|---|---|---|---|
| Product: | [Plasma] plasmashell | Reporter: | imaginator |
| Component: | Theme - Breeze | Assignee: | visual-design |
| Status: | RESOLVED UNMAINTAINED | ||
| Severity: | normal | CC: | jnerin, kde, kde, kdebugs, nate, plasma-bugs, tuomas, wedge009 |
| Priority: | HI | Keywords: | regression |
| Version: | 5.18.7 | ||
| Target Milestone: | 1.0 | ||
| Platform: | Other | ||
| OS: | Linux | ||
| Latest Commit: | Version Fixed In: | ||
OK, just for clarification: I'm seeing this only in 5.18.7.1, not in any other version - earlier or later. So this has in all probability nothing to do with "visual design". The probably easiest and most efficient way to put this right again is IMO to revert the changes made to LockScreenUi.qml between 5.18.6 and 5.18.7.1. This is what my patch does. On a general note: A long-term-version like 5.18 should not bring bad surprises. It's in its nature to be reliable and boring. Which IMO requires a conservative approach: only security-fixes and bug-fixes. And if possible a little bit of testing before a release. David looks like this is 697b103f5fad5b40b207eabcbce162d6672f5d91, reading the log of 13057013d55ae19e76d29b9edc96510e52da2a7a it looks like it was supposed to fix this This had the unfortunate side effect of breaking waking out of the screensaver mode with just the keyboard. but was reverted with c4a3a4e5b974fb309a6da61252b2b830d2d90683 (which caused the respin to 18.7.1) Should we just revert the whole thing on the LTS branch? :( I have a similar issue, also in Plasma 5.18.7, but even mouse movement doesn't allow me to unlock the screen. Not sure if my issue is the same as this one, then. Details: https://bugs.kde.org/show_bug.cgi?id=370676#c13 (In reply to Wedge009 from comment #4) > I have a similar issue, also in Plasma 5.18.7, but even mouse movement > doesn't allow me to unlock the screen. Not sure if my issue is the same as > this one, then. > > Details: https://bugs.kde.org/show_bug.cgi?id=370676#c13 You probably have to update to 5.18.7.1. See: https://bugs.kde.org/show_bug.cgi?id=438498 (In reply to Nate Graham from comment #3) > Should we just revert the whole thing on the LTS branch? :( What would you gain by keeping it? Only frustrated users and bad word of mouth. I'd do it this way: 1) Revert 2) If the changes were really important, rework them and then apply them again after thorough testing. If not, forget about them for the LTS branch. I only just had Plasma 5.18.7.1 become available for me. While I have the lock screen restored in the sense that I can input password again, I can confirm the original report that only mouse movement brings up the input widget. If left idle and the lock screen is left with only the time/date, key presses do not bring up the input widget. (In reply to imaginator from comment #5) > You probably have to update to 5.18.7.1. See: > https://bugs.kde.org/show_bug.cgi?id=438498 Thanks: I only just had those packages become available just before noticing this. *** Bug 440707 has been marked as a duplicate of this bug. *** This is still not fixed in Plasma-5.18.8 although the changelog says "Revert “[lookandfeel] Fix wake existing screensaver mode with key presses”. Commit. Fixes bug #435233". Bug #435233, however, is IMO something quite different, namely "Unable to authenticate after screen lock". Anyway - fixing #439604 is actually easy, as shown above: simply revert the patch that caused it. Yes, it's still an issue (albeit minor) as of Plasma 5.18. I think bug 450081 is a duplicate of this. The Plasma 5.18 LTS is no longer formally supported now that we have released the 5.24 LTS, so I'm afraid there isn't any chance this will ever be fixed for 5.18 users, outside of distro-specific patching. :( However since the same issue is still present in Plasma 5.24, let's continue the conversation in Bug 449857. Though I understand the reasoning with limited resources to just focus on the newly released 5.24 LTS version, it's a shame that this regression wasn't fixed immediately and now all 5.18.x users are stuck for as long as their upstream package provider doesn't provide 5.24 packages (not taking into account that some people may not be ready to adopt the 5.24 version yet). For me, this bug was one of the very few that has hit me and still annoys me dozens of times every day. I know, and I'm sorry. :( (In reply to Nate Graham from comment #12) > The Plasma 5.18 LTS is no longer formally supported now that we have > released the 5.24 LTS, so I'm afraid there isn't any chance this will ever > be fixed for 5.18 users, outside of distro-specific patching. :( However > since the same issue is still present in Plasma 5.24, let's continue the > conversation in Bug 449857. You must be kidding. Seven months ago (and then again) I told you how to fix this not in "15 minutes" but in 15 seconds. And now the the next LTS-version still has the same issue? I hope that at least you don't have illusions about user-loyalty. (In reply to Nate Graham from comment #12) > ...However > since the same issue is still present in Plasma 5.24, let's continue the > conversation in Bug 449857. I also understand the need to focus limited time and resources, but I am uncertain if this bug is really the same as bug 449857 now that the original reporter has clarified that a click is needed to regain focus. For Plasma 5.18.8, at least, no click is needed. But it is a regression and a minor nuisance that mouse movement is needed to give access to the password input field - although I've kinda got used to it by now, I'd still prefer the original keyboard input behaviour. Will continue in the Plasma 5.24 bug report. (In reply to imaginator from comment #15) > (In reply to Nate Graham from comment #12) > > The Plasma 5.18 LTS is no longer formally supported now that we have > > released the 5.24 LTS, so I'm afraid there isn't any chance this will ever > > be fixed for 5.18 users, outside of distro-specific patching. :( However > > since the same issue is still present in Plasma 5.24, let's continue the > > conversation in Bug 449857. > > You must be kidding. Seven months ago (and then again) I told you how to fix > this not in "15 minutes" but in 15 seconds. And now the the next > LTS-version still has the same issue? > > I hope that at least you don't have illusions about user-loyalty. Why didn't you submit a ptach to fix it then? (In reply to David Redondo from comment #17) > (In reply to imaginator from comment #15) > > (In reply to Nate Graham from comment #12) > > > The Plasma 5.18 LTS is no longer formally supported now that we have > > > released the 5.24 LTS, so I'm afraid there isn't any chance this will ever > > > be fixed for 5.18 users, outside of distro-specific patching. :( However > > > since the same issue is still present in Plasma 5.24, let's continue the > > > conversation in Bug 449857. > > > > You must be kidding. Seven months ago (and then again) I told you how to fix > > this not in "15 minutes" but in 15 seconds. And now the the next > > LTS-version still has the same issue? > > > > I hope that at least you don't have illusions about user-loyalty. > > Why didn't you submit a ptach to fix it then? Please? I reported the problem, I analyzed it, showed how to fix it (twice) by simply reverting a patch and now you have the nerve of asking such a question? Very telling. I suggest you reflect a bit on your mindset. I also have this issue in Ubuntu 20.04 with plasma-workspace 5.18.8. Thanks for the fix imaginator! I tested your fix and since it worked, I also added a patch to downstream bug here: https://bugs.launchpad.net/ubuntu/+source/plasma-workspace/+bug/1961447 Let's see if Ubuntu devs are more willing to do something about this issue. At least the 20.04 should still be maintained (https://ubuntu.com/about/release-cycle). |
In Plasma-5.18.7.1 the textbox/loginbox to unlock the screen after suspend/hibernate only appears after a movement of the mouse, not after input via the keyboard. The familiar and efficient behaviour is that entering the password right away makes the loginbox appear. I have rebuilt plasma-workspace-5.18.7.1 with the following patch applied which restores the familiar behaviour: --- a/lookandfeel/contents/lockscreen/LockScreenUi.qml +++ b/lookandfeel/contents/lockscreen/LockScreenUi.qml @@ -227,12 +227,6 @@ PlasmaCore.ColorScope { height: lockScreenRoot.height + units.gridUnit * 3 focus: true //StackView is an implicit focus scope, so we need to give this focus so the item inside will have it - // this isn't implicit, otherwise items still get processed for the scenegraph - visible: opacity > 0 - // changing enabled will toggle if an item can have activeFocus, which otherwise - //keeps the text cursor blinking even when invisble - enabled: visible - initialItem: MainBlock { id: mainBlock lockScreenUiVisible: lockScreenRoot.uiVisible Tested OK after suspend/hibernate and a locked screen.