Summary: | Maximize button sometimes appears even in non-resizable windows with xdg-decoration | ||
---|---|---|---|
Product: | [Plasma] kwin | Reporter: | David Gow <david> |
Component: | wayland-generic | Assignee: | KWin default assignee <kwin-bugs-null> |
Status: | RESOLVED FIXED | ||
Severity: | normal | CC: | kde, nate |
Priority: | NOR | ||
Version: | 5.22.2 | ||
Target Milestone: | --- | ||
Platform: | Other | ||
OS: | Linux | ||
Latest Commit: | https://invent.kde.org/plasma/kwin/commit/5fe6de699ca0cad9934197b317c93bcc4f41b117 | Version Fixed In: | 5.23 |
Attachments: | test program |
Description
David Gow
2021-07-07 04:33:06 UTC
Created attachment 139916 [details]
test program
I've used the attached test app On X state seems to be correctly propagated: - Breeze decoration does not draw a maximize button (but layouting breaks so a breeze bug) On Wayland decoration buttons do not change. I've also tested with another decoration that draws the maximize button disabled if the window is not maxmizable. On X this happens on Wayland not A possibly relevant merge request was started @ https://invent.kde.org/plasma/kwin/-/merge_requests/1156 Git commit 5fe6de699ca0cad9934197b317c93bcc4f41b117 by David Redondo. Committed on 07/07/2021 at 12:17. Pushed by davidre into branch 'master'. Handle when a xdg-toplevel changes its min or max size We previously never emitted maximiziableChanged() meaning we never synced the state to the decoration. M +14 -0 src/xdgshellclient.cpp M +2 -0 src/xdgshellclient.h https://invent.kde.org/plasma/kwin/commit/5fe6de699ca0cad9934197b317c93bcc4f41b117 |