Bug 439422

Summary:	Can't name tag after older name of renamed tag.
Product:	[Applications] krita	Reporter:	Alan North <alanscodelog>
Component:	Tagging	Assignee:	Tiar <tamtamy.tymona>
Status:	RESOLVED FIXED
Severity:	normal	CC:	tamtamy.tymona
Priority:	NOR	Keywords:	regression, release_blocker
Version First Reported In:	nightly build (please specify the git hash!)
Target Milestone:	---
Platform:	Microsoft Windows
OS:	Microsoft Windows
Latest Commit:	527355cab0d4f536ed	Version Fixed/Implemented In:	5.0
Sentry Crash Report:

Description Alan North 2021-07-02 22:35:36 UTC

I opened the database and the issue seems to be that the tag url isn't getting changed. This happens even after restarting after the rename.

STEPS TO REPRODUCE
1. Create new tag, `Test`.
2. Rename tag.
3. Try to create new tag named `Test`.

OBSERVED RESULT
Fails silently.
If doing this from a resource, if the resource was already in the old tag, it will also fail silently, but if it wasn't, it will add the resource to the old tag. 

EXPECTED RESULT
Tag can be created. Resource is assigned to newly created tag.

SOFTWARE/OS VERSIONS
Windows 10
Krita: b4a6f8041a

Comment 1 Tiar 2021-07-28 21:39:17 UTC

Maybe we should consider changing the url on rename, then... Even for default tags, if the user renames it, there is a chance the translations won't fit any longer anyway, so there is no point in keeping the url the same, I guess. 

So, if the user renames the tag, Krita would change the url to match the name. Then this issue won't happen. And it shouldn't hurt the default tags, or other things, I guess... if the new url can't be used, Krita can just tell the user whether they want to overwrite/replace, or just use the other tag (or cancel), I guess.

That needs discussion with Halla, though. Maybe there are other options.

Comment 2 Tiar 2021-08-09 12:52:13 UTC

That should be fixed between dea9c2a5417cd8c3 and 527355cab0d4f536ed