Bug 439309

Summary:	the Media Player plasmoid doesn't clear the player list until all players are closed
Product:	[Plasma] plasmashell	Reporter:	Reiddragon <this.is.reid>
Component:	Media Player	Assignee:	Kai Uwe Broulik <kde>
Status:	RESOLVED FIXED
Severity:	normal	CC:	plasma-bugs
Priority:	NOR
Version:	5.22.2
Target Milestone:	1.0
Platform:	Arch Linux
OS:	Linux
Latest Commit:	https://invent.kde.org/plasma/plasma-workspace/commit/58fecd9ba1e1a45cd5ab01f0832a3b06ed818c5a	Version Fixed In:	5.23.3

Description Reiddragon 2021-06-29 18:05:09 UTC

SUMMARY
the Media Player plasmoid doesn't clear the player list until all players are closed

STEPS TO REPRODUCE
1. open 2 media player and make sure they both get added to the plasmoid
2. close one
3. check the plasmoid

OBSERVED RESULT
the closed player won't get removed from the list; closing all players will however properly clear the list

EXPECTED RESULT
players should get removed from the list as they're closed

SOFTWARE/OS VERSIONS
KDE Plasma Version: 5.22.2
KDE Frameworks Version: 5.83
Qt Version: 5.15.2

ADDITIONAL INFORMATION

Comment 1 Kai Uwe Broulik 2021-06-30 20:16:09 UTC

Can confirm, getting an error: file:///usr/share/plasma/plasmoids/org.kde.plasma.mediacontroller/contents/ui/main.qml:306: TypeError: Value is undefined and could not be converted to an object

Comment 2 Bug Janitor Service 2021-06-30 20:25:23 UTC

A possibly relevant merge request was started @ https://invent.kde.org/plasma/plasma-workspace/-/merge_requests/953

Comment 3 Kai Uwe Broulik 2021-07-02 18:10:25 UTC

Git commit 36ed4658c673cc2f5350e8f852880b503441dea9 by Kai Uwe Broulik.
Committed on 02/07/2021 at 18:10.
Pushed by broulik into branch 'master'.

[Media Player] Skip source if it doesn't exist

We get `sourceRemoved` emitted before the source is actually removed
from the list.

This is a change from 5984d4960fa5ecf60a20b1fbc782fb841faa4af7
in plasma-framework but better be safe than sorry.
FIXED-IN: 5.23.3

M  +8    -2    applets/mediacontroller/contents/ui/main.qml

https://invent.kde.org/plasma/plasma-workspace/commit/36ed4658c673cc2f5350e8f852880b503441dea9

Comment 4 Kai Uwe Broulik 2021-07-02 18:10:58 UTC

Git commit 58fecd9ba1e1a45cd5ab01f0832a3b06ed818c5a by Kai Uwe Broulik.
Committed on 02/07/2021 at 18:10.
Pushed by broulik into branch 'Plasma/5.22'.

[Media Player] Skip source if it doesn't exist

We get `sourceRemoved` emitted before the source is actually removed
from the list.

This is a change from 5984d4960fa5ecf60a20b1fbc782fb841faa4af7
in plasma-framework but better be safe than sorry.
FIXED-IN: 5.23.3


(cherry picked from commit 36ed4658c673cc2f5350e8f852880b503441dea9)

M  +8    -2    applets/mediacontroller/contents/ui/main.qml

https://invent.kde.org/plasma/plasma-workspace/commit/58fecd9ba1e1a45cd5ab01f0832a3b06ed818c5a