| Summary: | [Okular] : Closing the Print Preview still/again causes a crash | ||
|---|---|---|---|
| Product: | [Applications] okular | Reporter: | RJVB <rjvbertin> |
| Component: | general | Assignee: | Okular developers <okular-devel> |
| Status: | RESOLVED DUPLICATE | ||
| Severity: | crash | Keywords: | drkonqi |
| Priority: | NOR | ||
| Version First Reported In: | unspecified | ||
| Target Milestone: | --- | ||
| Platform: | Compiled Sources | ||
| OS: | Linux | ||
| Latest Commit: | Version Fixed/Implemented In: | ||
| Sentry Crash Report: | |||
|
Description
RJVB
2021-06-27 10:19:49 UTC
And FWIW, PageView::capability() needs to check every one of the QActions in the d-ptr before accessing them, because aViewContinuous, aViewMode and aTrimMargins can all turn out to be a nullptr. Add a qDebug if you want to be able to avoid this from happening upstream, but please don't just "protect" the actual dereferencing with an assert. The user should NOT experience crashes if the developer(s) missed something and they shouldn't have to be the ones detecting such ommissions! > This is the exact same crash as the Okular4 one in the linked report which I reported years ago and that was supposed to be fixed. I don’t think so. Here you write: > [...] > #9 QAction::isChecked (this=0x0) at > /opt/local/var/lnxports/build/_opt_local_site-ports_aqua_qt5-kde-devel/qt5-kde-devel/work/qt-everywhere-opensource-src-5.9.8/qtbase/src/widgets/kernel/qaction.cpp:986 > #10 0x00007efbfd825cd3 in PageView::capability (this=0x22a38f0, capability=Okular::View::Continuous) at > /opt/local/var/lnxports/build/_opt_local_site-ports_kf5_kf5-okular/kf5-okular-devel/work/okular-5/ui/pageview.cpp:1607 > [...] But in https://bugs.kde.org/show_bug.cgi?id=348000 you wrote: > [...] > frame #8: 0x00000001080a6b24 > QtGui`QAction::setEnabled(this=0x0000000000000000, b=false) + 4 at qaction.cpp:1113 > frame #9: 0x000000010dcf8dc8 > okularpart.dylib`PageView::slotRelayoutPages(this=<unavailable>) + 600 at pageview.cpp:4139 > [...] The crash you have reported here is fixed with 6e170312d8560963108365ee9e5c124d5c76f0e9. *** This bug has been marked as a duplicate of bug 415340 *** Well, this is strange, I'm convinced that DrKonqi showed me a backtrace of the same bug, but I must have gotten confused. I am positive though that it didn't suggest bug 415340 - evidently I would not have filed another ticket if I had found that one. Yes, the automatic duplicate suggestions are not very clever. :D |