Bug 439160

Summary:	[brush preset docker] Krita 5 minimum width is larger than in Krita 4
Product:	[Applications] krita	Reporter:	David REVOY <info>
Component:	Dockers	Assignee:	Tiar <tamtamy.tymona>
Status:	RESOLVED FIXED
Severity:	normal	CC:	halla, lynx.mw+kde, tamtamy.tymona
Priority:	NOR
Version First Reported In:	git master (please specify the git hash!)
Target Milestone:	---
Platform:	Other
OS:	Linux
Latest Commit:		Version Fixed/Implemented In:
Sentry Crash Report:
Attachments:	^ Visual description of the request, (comparing 4.x with 5.x) Video showing the issue with the item viewer A video showing the same effect but on normal-sized thumbnails Comparison of Krita 5 and Krita 4

Description David REVOY 2021-06-25 16:56:58 UTC

Created attachment 139662 [details]
^ Visual description of the request, (comparing 4.x with 5.x)

Hi,
I tried to setup my usual layout of docker in Krita 5 and I saw Krita 5 couldn't reproduce the column of preset as I'm using on Krita 4 without having a gutter gap on the right. (See attachement for a visual). 

As a workaround, I can expand manually to larger icons to fill the gap, but it result in less preset visible vertically for me. 

That's why I do the resquest of being possible to shrink the docket a little bit more horyzontaly if possible. Thank you :) 

version: Krita 5, ( 6822476683de6f9adb2ad1aa019894a6d109ad60 ) appimage from  https://invent.kde.org/graphics/krita/-/merge_requests/922 (Popup Palette Improvements)
OS: Kubuntu Linux 20.04.LTS

Comment 1 Tiar 2021-07-09 15:22:40 UTC

Created attachment 139969 [details]
Video showing the issue with the item viewer

It's way trickier than it looks :( I checked *everywhere* and could not find a place where setting minimal size would change the width of the docker. Note: neither the new button on top nor the new checkbox on the bottom are blocking the width, from my experiments.

I think there might be an issue with the item viewer, actually - I see trouble with it finding an optimal size for the thumbnails. I'm not sure if it's related or not, but I'm including a video showing this effect.

Comment 2 Tiar 2021-07-09 15:23:19 UTC

Created attachment 139970 [details]
A video showing the same effect but on normal-sized thumbnails

Comment 3 Lynx3d 2021-09-03 06:32:38 UTC

I just realized what the problem is:
It's the (apparently very old?) KoDockWidgetTitleBar we brought back with Krita 5, their MinimumSizeHint by default forces the docker title text to fit in the widget (if we ignore the fact that the calculation seems off anyway and it overlaps with the float button).

Comment 4 Tiar 2021-09-20 12:31:23 UTC

Yeah I'm not convinced, because when David checked recently, that change (titlebar->setTextVisibilityMode(KoDockWidgetTitleBar::TextCanBeInvisible);) didn't actually make the docker smaller, because... it's already small enough. Basically some other changes were enough to fix that.

The abovementioned change now only changes the text to end with ... instead of slightly overlap with the buttons, is it something desireable?

Also I still believe there is some issue with the listview or view of the resources itself, even if it turns out irrelevant in this case.

Comment 5 Halla Rempt 2022-09-20 08:34:50 UTC

Created attachment 152248 [details]
Comparison of Krita 5 and Krita 4

I don't think this is actual anymore? Now the "Tag" text label is gone the min size is the same as in krita 4.

Comment 6 Halla Rempt 2022-09-20 08:35:01 UTC

Setting to needinfo

Comment 7 David REVOY 2022-09-20 11:06:24 UTC

Hey @Halla, yes, this one was fixed on the fly before Krita 5 release, but I can't remember who did it. It probably was on IRC and the bug report wasn't auto-closed. Thank you for the big triaging you are doing today. This one can be set to Resolved→Fixed.