| Summary: | Create/Edit Resource Bundle dialogue is using the name "Brushes" for brushtips type | ||
|---|---|---|---|
| Product: | [Applications] krita | Reporter: | Tyson Tan <tysontanx> |
| Component: | Resource Management | Assignee: | Krita Bugs <krita-bugs-null> |
| Status: | RESOLVED FIXED | ||
| Severity: | normal | CC: | tamtamy.tymona |
| Priority: | NOR | ||
| Version First Reported In: | 4.4.5 | ||
| Target Milestone: | --- | ||
| Platform: | unspecified | ||
| OS: | All | ||
| Latest Commit: | https://invent.kde.org/graphics/krita/commit/cf588a7f0c41d9bf52322c39b269415b0dc004bd | Version Fixed In: | |
| Sentry Crash Report: | |||
| Attachments: | Create Resource Bundle dialogue brushtip type is named as Brushes | ||
The current name for the brush tip images resource type name is "Brush Tips" and it should be used everywhere (here it was a mistake), and the current paintoppresets/brush presets resource type name is "Brush Presets". If that should be changed, then it needs wider discussion or at least Halla's approval. However the "Brushes" in the bundle manager is easy to fix, and I guess *removing* strings is fine in the string freeze, right? (It will be replaced by strings defined in other parts of the code, namely ResourcesTypes.h, which is what all other parts of Krita use). If you confirm, I'll push a fix for that today. Hi Tiar, I agree to just fix the "Brushes" to Brush Tips". Git commit cf588a7f0c41d9bf52322c39b269415b0dc004bd by Agata Cacko. Committed on 22/06/2021 at 15:07. Pushed by tymond into branch 'master'. Fix duplicate resource type names in DlgCreateBundle Before this commit, resource type names in DlgCreateBundle were hardcoded, usually duplicates from the strings in ResourceName namespace in ResourceTypes.h. This commit replaces them with strings from ResourceTypes.h. M +7 -8 plugins/extensions/resourcemanager/dlg_create_bundle.cpp https://invent.kde.org/graphics/krita/commit/cf588a7f0c41d9bf52322c39b269415b0dc004bd Thanks Tiar! :D |
Created attachment 139540 [details] Create Resource Bundle dialogue brushtip type is named as Brushes Krita's Create/Edit Resource Bundle dialogue is using the name "Brushes" for brushtip type. Since they are precisely brushtips, we should name them here as such. Many users are having trouble telling the differences between "Brushes" and "Brush Presets". I think "Brush Tip Images" is more accurate instead of "Brushes/brushtips". It'll help users to understand what they really are, and thus not mixing them with the Brush Presets.