Summary: | Visual glitch in context menu when the shift modifier key is pressed | ||
---|---|---|---|
Product: | [Plasma] plasmashell | Reporter: | Derek Christ <christ.derek> |
Component: | Folder | Assignee: | Eike Hein <hein> |
Status: | RESOLVED FIXED | ||
Severity: | normal | CC: | nate, plasma-bugs |
Priority: | NOR | ||
Version: | master | ||
Target Milestone: | 1.0 | ||
Platform: | Other | ||
OS: | Linux | ||
See Also: | https://bugs.kde.org/show_bug.cgi?id=442485 | ||
Latest Commit: | https://invent.kde.org/plasma/plasma-desktop/commit/f830ceeaf012a9f87b7c0b2b2bb9b095de107da4 | Version Fixed In: | 5.23 |
Attachments: | Glitch |
Description
Derek Christ
2021-06-19 22:15:29 UTC
Can reproduce. Feel free to submit a merge request to harmonize the implementations. A possibly relevant merge request was started @ https://invent.kde.org/plasma/plasma-desktop/-/merge_requests/552 Git commit f830ceeaf012a9f87b7c0b2b2bb9b095de107da4 by Derek Christ. Committed on 09/09/2021 at 19:01. Pushed by davidedmundson into branch 'master'. Introduce RemoveAction for context menu The RemoveAction can either represent the delete action or the move to trash action, depending on the shift modifier state. This inplace swapping instead of adding and removing both actions fixes a visual glitch that could be noticed by pressing and releasing the shift key multiple times. FIXED-IN: 5.22 M +1 -0 containments/desktop/plugins/folder/CMakeLists.txt M +28 -46 containments/desktop/plugins/folder/foldermodel.cpp M +0 -2 containments/desktop/plugins/folder/foldermodel.h A +99 -0 containments/desktop/plugins/folder/removeaction.cpp [License: GPL(v2.0+)] A +49 -0 containments/desktop/plugins/folder/removeaction.h [License: GPL(v2.0+)] https://invent.kde.org/plasma/plasma-desktop/commit/f830ceeaf012a9f87b7c0b2b2bb9b095de107da4 |