Bug 438756

Summary:	Vector shapes filled with gradient bug
Product:	[Applications] krita	Reporter:	grum999
Component:	Tools/Vector	Assignee:	sh_zam <shzam>
Status:	RESOLVED FIXED
Severity:	normal	CC:	ahab.greybeard, shzam
Priority:	NOR	Keywords:	regression
Version First Reported In:	nightly build (please specify the git hash!)
Target Milestone:	---
Platform:	Other
OS:	Linux
Latest Commit:	https://invent.kde.org/graphics/krita/commit/eaaedfe04598bf5ecb95418ffb30f3fa802eba4f	Version Fixed/Implemented In:
Sentry Crash Report:
Attachments:	example file ready to use Minimum Set for the problem

Description grum999 2021-06-16 17:30:15 UTC

Created attachment 139404 [details]
example file ready to use

SUMMARY


From KA  topic
https://krita-artists.org/t/vector-shapes-filled-with-gradient-bug/25114?u=grum999



STEPS TO REPRODUCE
Download attached example file

1. Select vector layer
2. Select "Select Shapes Tool"
3. Unselect everything (no shape selected)
4. Select all shapes


OBSERVED RESULT
When all shapes are selected, all shapes are set will a fill gradient


EXPECTED RESULT
Shapes brush/fill shouldn't be modified when they're just selected



SOFTWARE/OS VERSIONS
krita-5.0.0-prealpha-4f029a8-x86_64.appimage


ADDITIONAL INFORMATION
Not able to reproduce it systematically.
See video example and additional information on KA topic


Grum999

Comment 1 Ahab Greybeard 2021-06-17 14:49:17 UTC

Created attachment 139436 [details]
Minimum Set for the problem

I can confirm this with the example file supplied for the Jun 16 5.0.0-prealpha (git 949e869) appimage on Debian 10.

However, it doesn't happen for every session when I open the .kra file.

When it did happen, I disassembled the image by moving away one object at a time and working on the remainder. Eventually I obtained a 'minimum set' of three objects that showed the behaviour. See attachment: 'Minimum Set for the problem'.
Ater moving the short line object away, the two remaining objects did not show the problem. Then after moving the short line object back, the three objects no longer showed the problem.

I've tried various manipulations in an attempt to determine a 'definite cause' and haven't been able to find one that's repeatable.

Comment 2 grum999 2021-06-18 19:13:34 UTC

(In reply to Ahab Greybeard from comment #1)
> Created attachment 139436 [details]
> I've tried various manipulations in an attempt to determine a 'definite
> cause' and haven't been able to find one that's repeatable.

Yes, same problem.

The only reproducible thing I can tell is, when the problem starts on a document, problem occurs when you select everything if nothing is previously selected.
If at least on shape is selected, the problem *seems* to not occurs


Grum999

Comment 3 sh_zam 2021-06-21 09:10:25 UTC

I can't reproduce this on krita-4.4.5, so a regression. I'm taking this.

Comment 4 sh_zam 2021-06-21 13:31:22 UTC

Git commit eaaedfe04598bf5ecb95418ffb30f3fa802eba4f by Sharaf Zaman.
Committed on 21/06/2021 at 13:28.
Pushed by szaman into branch 'master'.

Bugfix: Vector shapes get filled with gradient

M  +8    -0    libs/ui/widgets/KoFillConfigWidget.cpp

https://invent.kde.org/graphics/krita/commit/eaaedfe04598bf5ecb95418ffb30f3fa802eba4f

Comment 5 grum999 2021-06-23 16:50:12 UTC

(In reply to Sharaf from comment #4)
> Git commit eaaedfe04598bf5ecb95418ffb30f3fa802eba4f by Sharaf Zaman.
> Committed on 21/06/2021 at 13:28.
> Pushed by szaman into branch 'master'.
On my side, after many differents tests, I can't reproduce the problem.

So I can confirm problem is fixed :)

Grum999