Bug 438701

Summary: Missing translations for a few common buttons like OK and Cancel (digiKam official builds only)
Product: [Applications] digikam Reporter: Tyson Tan <tysontanx>
Component: Usability-i18nAssignee: Digikam Developers <digikam-bugs-null>
Status: RESOLVED FIXED    
Severity: normal CC: aspotashev, caulier.gilles, luigi.toscano, metzpinguin
Priority: NOR    
Version: 7.4.0   
Target Milestone: ---   
Platform: Other   
OS: All   
Latest Commit: Version Fixed In: 7.5.0
Sentry Crash Report:
Attachments: digikam missing translation of some basic buttons (Simplified Chinese)
digikam missing translation of some basic buttons (Japanese)
digikam missing translation of some basic buttons (French)
digikam missing translations in the menu

Description Tyson Tan 2021-06-16 01:51:02 UTC
Buttons like [OK] and [Cancel] are missing translation in digiKam's OWN builds (Windows/macOS/Linux). But the DISTRO builds have them.

This has been a common problem across all KDE official standalone packages since ever. 

Recently the Krita developers have solved the problem:

https://bugs.kde.org/show_bug.cgi?id=395338
https://invent.kde.org/graphics/krita/commit/6ddad6502f3742c08ca89c3d1db36f331cf95e55

It's now working correctly in Krita's latest nighlies.

Maybe we can use the same trick to fix digiKam's too?
Comment 1 caulier.gilles 2021-06-16 02:01:46 UTC
Hi,

Outside the fact that Krita as patched source code to use KF5 translations in favor of Qt translations for common action strings i18n, can you confirm that digiKam problem still exists for 7.3.0 pre-release bundles available here :

https://files.kde.org/digikam/

GilleS Caulier
Comment 2 Tyson Tan 2021-06-16 02:19:09 UTC
(In reply to caulier.gilles from comment #1)
> Hi,
> 
> Outside the fact that Krita as patched source code to use KF5 translations
> in favor of Qt translations for common action strings i18n, can you confirm
> that digiKam problem still exists for 7.3.0 pre-release bundles available
> here :
> 
> https://files.kde.org/digikam/
> 
> GilleS Caulier

Yes, it still happens.

It appears that for standalone packages, KDE applications need Qttranslation strings for some very basic buttons. We have strings for OK and Cancel buttons in Krita's POT files, the app never loads them. It has plagued us for so many years.

I have discussed my initial findings when translating Qt in this comment:
https://bugs.kde.org/show_bug.cgi?id=395338#c68
Comment 3 Maik Qualmann 2021-06-16 04:25:42 UTC
We are now also loading the Qt basic translation. At least in the German language I can no longer see any problems. Can you give an example of the language and dialog with which the problem exists?

Maik
Comment 4 Maik Qualmann 2021-06-16 05:57:22 UTC
I'm referring to the digiKam Windows bundle. I see that the file for the simplified Chinese translation zh_CN is not included. When I activate traditional Chinese translation, all Qt dialog buttons are translated. Now the question arises, why does Qt not have a zh_CN translation file? Or do we have to install something optional from Qt when creating the package?

Maik
Comment 5 Maik Qualmann 2021-06-16 06:10:46 UTC
Ok, problem found we are currently only loading qtbase_COUNTRY_CODE.qm, but the simplified Chinese translation is in qt_COUNTRY_CODE.qm. We can easily fix that.

Maik
Comment 6 caulier.gilles 2021-06-16 06:13:08 UTC
Maik,

This depend of which kind of bundle your talk. 

MacOS => Qt come from Macports
Windows => Qt come from MXE
Linux => Qt is compiled from official source (look in project/bundles/3rdparty/ext_qt)

I don't know if a special package to support Chinese language is necessary. QTranslator must be installed as well.

But if i look in French translations of current MacOS version for ex, i see few basic entries in main menu not translated:

https://i.imgur.com/kpF0X6V.png
https://i.imgur.com/EfbwImd.png
https://i.imgur.com/YJynGYI.png

Gilles
Comment 7 Tyson Tan 2021-06-16 06:47:00 UTC
Created attachment 139364 [details]
digikam missing translation of some basic buttons (Simplified Chinese)

Simplified Chinese (zh_CN)
Comment 8 Tyson Tan 2021-06-16 06:48:03 UTC
Created attachment 139365 [details]
digikam missing translation of some basic buttons (Japanese)

Japanese (JA)
Comment 9 Tyson Tan 2021-06-16 06:54:39 UTC
Created attachment 139366 [details]
digikam missing translation of some basic buttons (French)

French (FR)
Comment 10 Tyson Tan 2021-06-16 07:04:44 UTC
Please pay attention to the Configure dialogue's buttons:
* [OK]
* [Cancel]
* [Help]
are not translated. Similar situation for every other dialogue. All languages are affected.

Tested with digiKam 7.2.0 official appimage.

Please do not mistake the bug as "the zh_CN translation as a whole cannot be loaded". There is NOTHING wrong with digikam's own translations! They can be loaded just fine! digiKam's Simplified Chinese translation is loaded properly on my Windows 10 test system.
Comment 11 Tyson Tan 2021-06-16 07:19:35 UTC
I must emphasize again that this is NOT Simplified Chinese specific issue. digiKam's own Simplified Chinese translation is loaded just fine using digiKam's official builds -- at least I can confirm the Appimage and Windows builds are fine. 

Buttons mentioned in Comment 7, 8, 9, 10 are the only place the translations are missing. And it is the same for all languages.

Comment 4 and Comment 5 reminded me of once under Linux digiKam refused to load certain locale after I changed the SYSTEM's locale settings. I don't think it has anything to do with digiKam itself but some FOSS internationalization complications. I'm afraid if you make changes based on those findings, you could probably end up break things rather than fixing it.

What I reported is a common issue for all KDE applications. Krita, digiKam, Kdenlive, Kate, Kstars all lacks translations for those buttons, but everything else is fully translated. What Krita figured out was the only thing that worked after many years of wild goose chasing.
Comment 12 Maik Qualmann 2021-06-16 12:52:00 UTC
@Gilles, these missing translations in the screenshots are in the not yet complete main translation. The French translators have to do something here. Thanks to the user "herb", everything has now been translated into German.

@Tyson, In the current developer version of digiKam-7.3.0, we are already loading the Qt translations. Only a few with a different file prefix won't load yet, I'll fix that tonight. The Japanese language works.

Maik
Comment 13 Tyson Tan 2021-06-16 14:19:03 UTC
Thanks Maik. I double checked and JP version indeed has translations for Cancel and Help -- I though it wasn't translated when I saw "OK", but it seems they decided to use "OK" as is.
Comment 14 Maik Qualmann 2021-06-16 17:09:18 UTC
Git commit c8c95a0477a55fbf8b9276b4812f8f6b00869106 by Maik Qualmann.
Committed on 16/06/2021 at 17:08.
Pushed by mqualmann into branch 'master'.

try to fix loading Qt translations

M  +20   -10   core/app/main/main.cpp
M  +20   -10   core/showfoto/main/main.cpp

https://invent.kde.org/graphics/digikam/commit/c8c95a0477a55fbf8b9276b4812f8f6b00869106
Comment 15 Luigi Toscano 2021-06-18 09:48:34 UTC
As mentioned elsewhere, this shouldn't be fixed independently by each and every application. Please let's try to work together to see why the default loading code doesn't load those translations in some conditions (as it works in some cases).
Comment 16 Maik Qualmann 2021-06-18 11:51:30 UTC
A uniform solution would be good, but I'm not sure if it is possible.
digiKam currently only loads the Qt translation in the AppImage, under MacOS or Windows.
There are no problems whatsoever with a KF5 desktop and digiKam as a native application. I can't say what it looks like under Ubuntu.
Furthermore, there are no problems loading the translations based on KI18n, all platforms work.
Only translations of Qt based on tr() are not automatically loaded.
I suspect that on a KF5 desktop, the Qt translations are already loaded when the desktop is started.

Maik
Comment 17 Maik Qualmann 2021-06-18 11:59:22 UTC
@Tyson
I see that in simplified Chinese all buttos from a Qt file dialog are now translated into digiKam. But not OK, Cancel and Help. How is that in a native application?

In Japanese, French, and German, OK is not translated. I can confirm for German that it is not translated in native applications either. By the way, I think it's right not to translate OK, at least in German.

Maik
Comment 18 Tyson Tan 2021-06-18 12:24:45 UTC
@Maik

On Archlinux KDE, the native digiKam has all those buttons translated. Same for other KDE apps.

Judging from Kubuntu, Ubuntu might have been the same as long as "qt5-translation" package is installed (it's not a hard dependence).

It is conventional for Chinese to translate "OK" to our local language:
Simplified Chinese: OK -> 确定
Traditional Chinese: OK -> 確定

This is universal across Windows/macOS/Android.

It would be fine if only "OK" was untranslated. But I'm not sure the majority of people can recognize "Cancel", "Help" or "Default".
Comment 19 caulier.gilles 2021-06-23 06:54:56 UTC
Maik,

The loading Qt translations under MacOS do not work as the QStandardPath used is not the right place, as we use a Mac bundle.

2 solutions: fix the code, or fix the place in the bundle to host Qt translations data.

Gilles
Comment 20 caulier.gilles 2021-06-23 07:08:37 UTC
Git commit 03c0ee9231d1f9c62a4696a93153f17c85aab42c by Gilles Caulier.
Committed on 23/06/2021 at 07:07.
Pushed by cgilles into branch 'master'.

move Qt translation files at the right place in MacOS bundle

M  +4    -0    project/bundles/macports/04-build-installer.sh

https://invent.kde.org/graphics/digikam/commit/03c0ee9231d1f9c62a4696a93153f17c85aab42c
Comment 21 caulier.gilles 2021-12-14 04:51:07 UTC
Hi all,

Stable digiKam 7.4.0 Windows Installer is published. Please check if problem is
reproducible.

Thanks in advance

Gilles Caulier
Comment 22 Tyson Tan 2021-12-14 08:01:12 UTC
Yes, the problem still exists. Not only that even more translations are now missing.
Comment 23 Tyson Tan 2021-12-14 08:06:03 UTC
Created attachment 144532 [details]
digikam missing translations in the menu

Many items in the main menus are now missing translations as well. This screenshot is from the 7.4.0 appimage. The missing strings are all Qt strings. We have completed the Qt translation long time ago. I think you should update the Qt translation used in the building system.
Comment 24 caulier.gilles 2021-12-14 09:21:18 UTC
The Qt 5.15.2 included in AppImage bundle is the last version published in open source. It's the official tarball. So since 7.3.0 we use it as well, and nothing as changed about translations.

Gilles Caulier
Comment 25 Tyson Tan 2021-12-14 11:36:10 UTC
Qt translation is not part of Qt, it's a separated project. KDE has been maintaining a branch of Qt 5 after the final official release, fixing its bugs and included updated Qt translations for many languages.

The OK/Cancel buttons come from Qt Translation. Krita solved this issue by building the binaries with a updated Qt+Qt Translation as I mentioned in the original description of this bug.

For the strings missing in comment 23, I suspect they are KDE framework translations. Since I'm also maintaining KDE Framework translations, I'm pretty sure those translations were completed long ago. There has to be something wrong in our building system.
Comment 26 caulier.gilles 2021-12-26 22:16:49 UTC
Tan,

About Qt5 maintenance including Qttranslations code from KDE git repository, did you talk about this branch :

https://invent.kde.org/qt/qt/qt5/-/tree/kde/5.15

Best

Gilles Caulier
Comment 27 caulier.gilles 2021-12-26 22:21:55 UTC
Tan,

As i can see in Krita bundle rules, it's Qt 5.12 LTS which is used actually. digiKam uses Qt 5.15.2 currently.

Best

Gilles Caulier
Comment 28 caulier.gilles 2021-12-29 06:32:02 UTC
Git commit be1361bd01135eeb56c5438068e928cc929f20e0 by Gilles Caulier.
Committed on 29/12/2021 at 06:29.
Pushed by cgilles into branch 'master'.

factorize standard Qt translation files loading.

M  +3    -57   core/app/main/main.cpp
M  +69   -1    core/app/utils/digikam_globals.cpp
M  +6    -0    core/app/utils/digikam_globals.h
M  +3    -58   core/showfoto/main/main.cpp

https://invent.kde.org/graphics/digikam/commit/be1361bd01135eeb56c5438068e928cc929f20e0
Comment 29 caulier.gilles 2021-12-29 12:43:40 UTC
Hi all and happy new year,

Some progress here : as i can see with MacOS package of 7.5.0, if i switch in another language as FR, DE, ES, IT, as can see only few entries not translated which are not similar than problems reported in main menu or dialog buttons.

It still few backport to do from krita project that i will do ASAP, and check Windows and AppImage bundles. After that, if all is fine, I think this file can be closed...

Best
Gilles Caulier
Comment 30 caulier.gilles 2021-12-29 12:52:18 UTC
This is a screenshot in Chinese under MacOS :

https://i.imgur.com/UVQ30D3.png

As i can see, all is mostly translated, excepted the Settings/Show Toolbar entry (it's also the case in another languages).

Some KF5 dialog buttons still in English as i can see, but it's normal, the KF5::ECM Qt translations are not loaded at run time as krita do. I will patch digiKam in this way.

Best

Gilles
Comment 31 caulier.gilles 2021-12-29 14:24:03 UTC
Git commit d899d0a0409e719b7bed8ccd8dabcf24dc39d2e5 by Gilles Caulier.
Committed on 29/12/2021 at 14:21.
Pushed by cgilles into branch 'master'.

Bundles improvements: backport ECM translation files handling functions from Krita to solve missing basic i18n in menus and buttons from Qt core

M  +1    -1    core/app/main/main.cpp
M  +1    -271  core/app/utils/digikam_globals.cpp
M  +21   -4    core/app/utils/digikam_globals.h
C  +155  -246  core/app/utils/digikam_globals_bundles.cpp [from: core/app/utils/digikam_globals.cpp - 050% similarity]
A  +65   -0    core/app/utils/digikam_globals_p.h     [License: GPL (v2+)]
M  +1    -0    core/libs/widgets/CMakeLists.txt
M  +1    -1    core/showfoto/main/main.cpp

https://invent.kde.org/graphics/digikam/commit/d899d0a0409e719b7bed8ccd8dabcf24dc39d2e5
Comment 32 caulier.gilles 2021-12-29 23:02:57 UTC
Git commit 52197822b6abdf35ad73faaab8087c042469ba7c by Gilles Caulier.
Committed on 29/12/2021 at 23:02.
Pushed by cgilles into branch 'master'.

more qt catalogs to load with QApplication instance

M  +32   -7    core/app/utils/digikam_globals_bundles.cpp

https://invent.kde.org/graphics/digikam/commit/52197822b6abdf35ad73faaab8087c042469ba7c
Comment 33 caulier.gilles 2021-12-30 10:12:08 UTC
Voilà. In French, the AppImage print these messages at the bundle start:

[gilles@localhost Downloads]$ ./digiKam-7.5.0-20211230T083422-x86-64.appimage
-- digiKam Linux AppImage Bundle
-- Use 'help' as CLI argument to know all available options for digiKam application.
-- Notes: to integrate this bundle to your desktop, use AppImageLauncher.
--        to enable all debug messages on the console, use 'export QT_LOGGING_RULES="digikam*=true"'.
Check library libudev.so.0
Check library libxcb-dri3.so.0
Check library libcrypto.so.1.1
Check library libssl.so.1.1
-- Preloading shared libs: :/usr/lib64/libxcb-dri3.so.0:/usr/lib64/libcrypto.so.1.1:/usr/lib64/libssl.so.1.1
Digikam::DXmlGuiWindow::setupIconTheme: Breeze icons resource file found
Digikam::DXmlGuiWindow::setupIconTheme: Breeze-dark icons resource file found
Digikam::unloadQtTranslationFiles: Qt standard translations removed: 14
Digikam::loadStdQtTranslationFiles: Qt standard translations path: "/tmp/.mount_digiKaS2gcLk/usr/share/digikam/translations"
Digikam::loadStdQtTranslationFiles: Loaded Qt standard translations "fr_FR" from catalog "qt"
Digikam::loadStdQtTranslationFiles: Loaded Qt standard translations "fr_FR" from catalog "qtbase"
Digikam::loadStdQtTranslationFiles: Loaded Qt standard translations "fr_FR" from catalog "qt_help"
Digikam::loadStdQtTranslationFiles: Loaded Qt standard translations "fr_FR" from catalog "qtdeclarative"
Digikam::loadStdQtTranslationFiles: Loaded Qt standard translations "fr_FR" from catalog "qtmultimedia"
Digikam::loadStdQtTranslationFiles: Loaded Qt standard translations "fr_FR" from catalog "qtxmlpatterns"
Digikam::loadEcmQtTranslationFiles: Loaded Qt ECM translations "fr" from catalog "kauth5_qt"
Digikam::loadEcmQtTranslationFiles: Loaded Qt ECM translations "fr" from catalog "kbookmarks5_qt"
Digikam::loadEcmQtTranslationFiles: Loaded Qt ECM translations "fr" from catalog "kcodecs5_qt"
Digikam::loadEcmQtTranslationFiles: Loaded Qt ECM translations "fr" from catalog "kcompletion5_qt"
Digikam::loadEcmQtTranslationFiles: Loaded Qt ECM translations "fr" from catalog "kconfig5_qt"
Digikam::loadEcmQtTranslationFiles: Loaded Qt ECM translations "fr" from catalog "kcoreaddons5_qt"
Digikam::loadEcmQtTranslationFiles: Loaded Qt ECM translations "fr" from catalog "kdbusaddons5_qt"
Digikam::loadEcmQtTranslationFiles: Loaded Qt ECM translations "fr" from catalog "kglobalaccel5_qt"
Digikam::loadEcmQtTranslationFiles: Loaded Qt ECM translations "fr" from catalog "kitemviews5_qt"
Digikam::loadEcmQtTranslationFiles: Loaded Qt ECM translations "fr" from catalog "kwidgetsaddons5_qt"
Digikam::loadEcmQtTranslationFiles: Loaded Qt ECM translations "fr" from catalog "kwindowsystem5_qt"
Digikam::loadEcmQtTranslationFiles: Loaded Qt ECM translations "fr" from catalog "solid5_qt"
Digikam::loadEcmQtTranslationFiles: Loaded Qt ECM translations "fr" from catalog "kde5_xml_mimetypes"
Digikam::ApplicationSettings::setApplicationStyle: Switch to widget style:  "breeze"

Look like the qm translations catalogs loaded at startup are complete now. As i can see, all are translated properly in menu, dialog, buttons, tooltip. Few items still in English because strings are too recent and not yet processed by translator teams

Gilles Caulier
Comment 34 caulier.gilles 2021-12-30 11:13:09 UTC
Look the same trace captured under Windows with 7.5.0 pre-release installer (digiKam-7.5.0-20211230T100454-Win64) wit French translations:

[3616] digikam.general: Loading DrMinGw run-time...
[3616] digikam.general: DrMinGw: unsupported Windows version 7
[3616] digikam.widgets: Breeze icons resource file found
[3616] digikam.widgets: Breeze-dark icons resource file found
[3616] digikam.general: Qt standard translations removed: 13
[3616] digikam.general: Qt standard translations path: "C:/Program Files/digiKam/translations"
[3616] digikam.general: Loaded Qt standard translations "fr_FR" from catalog "qtbase"
[3616] digikam.general: Loaded Qt standard translations "fr_FR" from catalog "qt_help"
[3616] digikam.general: Loaded Qt ECM translations "en" from catalog "kcoreaddons5_qt"
[3616] digikam.general: Loaded Qt ECM translations "en" from catalog "kwidgetsaddons5_qt"
[3616] digikam.general: Loaded Qt ECM translations "fr" from catalog "kauth5_qt"
[3616] digikam.general: Loaded Qt ECM translations "fr" from catalog "kbookmarks5_qt"
[3616] digikam.general: Loaded Qt ECM translations "fr" from catalog "kcodecs5_qt"
[3616] digikam.general: Loaded Qt ECM translations "fr" from catalog "kcompletion5_qt"
[3616] digikam.general: Loaded Qt ECM translations "fr" from catalog "kconfig5_qt"
[3616] digikam.general: Loaded Qt ECM translations "fr" from catalog "kcoreaddons5_qt"
[3616] digikam.general: Loaded Qt ECM translations "fr" from catalog "kdbusaddons5_qt"
[3616] digikam.general: Loaded Qt ECM translations "fr" from catalog "kglobalaccel5_qt"
[3616] digikam.general: Loaded Qt ECM translations "fr" from catalog "kitemviews5_qt"
[3616] digikam.general: Loaded Qt ECM translations "fr" from catalog "kwidgetsaddons5_qt"
[3616] digikam.general: Loaded Qt ECM translations "fr" from catalog "kwindowsystem5_qt"
[3616] digikam.general: Loaded Qt ECM translations "fr" from catalog "solid5_qt"
[3616] digikam.general: Loaded Qt ECM translations "fr" from catalog "kde5_xml_mimetypes"
[3616] digikam.general: Loaded Qt ECM translations "fr" from catalog "kauth5_qt"
[3616] digikam.general: Loaded Qt ECM translations "fr" from catalog "kbookmarks5_qt"
[3616] digikam.general: Loaded Qt ECM translations "fr" from catalog "kcodecs5_qt"
[3616] digikam.general: Loaded Qt ECM translations "fr" from catalog "kcompletion5_qt"
[3616] digikam.general: Loaded Qt ECM translations "fr" from catalog "kconfig5_qt"
[3616] digikam.general: Loaded Qt ECM translations "fr" from catalog "kcoreaddons5_qt"
[3616] digikam.general: Loaded Qt ECM translations "fr" from catalog "kdbusaddons5_qt"
[3616] digikam.general: Loaded Qt ECM translations "fr" from catalog "kglobalaccel5_qt"
[3616] digikam.general: Loaded Qt ECM translations "fr" from catalog "kitemviews5_qt"
[3616] digikam.general: Loaded Qt ECM translations "fr" from catalog "kwidgetsaddons5_qt"
[3616] digikam.general: Loaded Qt ECM translations "fr" from catalog "kwindowsystem5_qt"
[3616] digikam.general: Loaded Qt ECM translations "fr" from catalog "solid5_qt"
[3616] digikam.general: Loaded Qt ECM translations "fr" from catalog "kde5_xml_mimetypes"
[3616] digikam.general: Switch to widget style:  "Fusion"
[3616] digikam.general: AlbumWatch is disabled
[3616] digikam.general: Database Parameters:

It's the same than with AppImage, all sound like perfectly translated in GUI.

Gilles Caulier
Comment 35 Maik Qualmann 2021-12-30 12:48:18 UTC
I tested the current Windows version. It's already looking pretty good, all KF5 texts are now translated (simplified Chinese language). The only missing items are "OK", "Cancel" and Help "e.g. from the setup dialog.

Maik
Comment 36 Maik Qualmann 2021-12-30 12:56:50 UTC
The OK is probably not translated is probably normal. The texts "Cancel" and "Help" are translated into French and German. The question in which translation file and where these texts were translated into the simplified Chinese language can perhaps be answered by Tyson.

Maik
Comment 37 caulier.gilles 2021-12-30 13:11:06 UTC
And finally, the MacOS debug trace with all French translation files loaded at start-up :

bash-3.2$ uname -a
Darwin MacBook-Pro-de-gilles.local 20.6.0 Darwin Kernel Version 20.6.0: Wed Nov 10 22:23:07 PST 2021; root:xnu-7195.141.14~1/RELEASE_X86_64 x86_64
bash-3.2$ pwd
/Applications/digiKam.org/digikam.app/Contents/MacOS
bash-3.2$ ls -al
total 48
drwxr-xr-x   3 root  wheel     96 30 déc 14:05 .
drwxr-xr-x  10 root  wheel    320 30 déc 14:05 ..
-rwxr-xr-x   1 root  wheel  99184 30 déc 13:06 digikam
bash-3.2$ ./digikam
digikam.widgets: Breeze icons resource file found
digikam.widgets: Breeze-dark icons resource file found
digikam.general: Qt standard translations removed: 0
digikam.general: Qt standard translations path: "/Applications/digiKam.org/digikam.app/Contents/Resources/translations"
digikam.general: Loaded Qt standard translations "fr_FR" from catalog "qt"
digikam.general: Loaded Qt standard translations "fr_FR" from catalog "qtbase"
digikam.general: Loaded Qt standard translations "fr_FR" from catalog "qt_help"
digikam.general: Loaded Qt standard translations "fr_FR" from catalog "qtdeclarative"
digikam.general: Loaded Qt standard translations "fr_FR" from catalog "qtmultimedia"
digikam.general: Loaded Qt standard translations "fr_FR" from catalog "qtxmlpatterns"
digikam.general: Loaded Qt ECM translations "en" from catalog "kcoreaddons5_qt"
digikam.general: Loaded Qt ECM translations "en" from catalog "kwidgetsaddons5_qt"
digikam.general: Loaded Qt ECM translations "fr" from catalog "kauth5_qt"
digikam.general: Loaded Qt ECM translations "fr" from catalog "kbookmarks5_qt"
digikam.general: Loaded Qt ECM translations "fr" from catalog "kcodecs5_qt"
digikam.general: Loaded Qt ECM translations "fr" from catalog "kcompletion5_qt"
digikam.general: Loaded Qt ECM translations "fr" from catalog "kconfig5_qt"
digikam.general: Loaded Qt ECM translations "fr" from catalog "kcoreaddons5_qt"
digikam.general: Loaded Qt ECM translations "fr" from catalog "kdbusaddons5_qt"
digikam.general: Loaded Qt ECM translations "fr" from catalog "kglobalaccel5_qt"
digikam.general: Loaded Qt ECM translations "fr" from catalog "kitemviews5_qt"
digikam.general: Loaded Qt ECM translations "fr" from catalog "kwidgetsaddons5_qt"
digikam.general: Loaded Qt ECM translations "fr" from catalog "kwindowsystem5_qt"
digikam.general: Loaded Qt ECM translations "fr" from catalog "solid5_qt"
digikam.general: Loaded Qt ECM translations "fr" from catalog "kde5_xml_mimetypes"
digikam.general: Loaded Qt ECM translations "fr" from catalog "kauth5_qt"
digikam.general: Loaded Qt ECM translations "fr" from catalog "kbookmarks5_qt"
digikam.general: Loaded Qt ECM translations "fr" from catalog "kcodecs5_qt"
digikam.general: Loaded Qt ECM translations "fr" from catalog "kcompletion5_qt"
digikam.general: Loaded Qt ECM translations "fr" from catalog "kconfig5_qt"
digikam.general: Loaded Qt ECM translations "fr" from catalog "kcoreaddons5_qt"
digikam.general: Loaded Qt ECM translations "fr" from catalog "kdbusaddons5_qt"
digikam.general: Loaded Qt ECM translations "fr" from catalog "kglobalaccel5_qt"
digikam.general: Loaded Qt ECM translations "fr" from catalog "kitemviews5_qt"
digikam.general: Loaded Qt ECM translations "fr" from catalog "kwidgetsaddons5_qt"
digikam.general: Loaded Qt ECM translations "fr" from catalog "kwindowsystem5_qt"
digikam.general: Loaded Qt ECM translations "fr" from catalog "solid5_qt"
digikam.general: Loaded Qt ECM translations "fr" from catalog "kde5_xml_mimetypes"
digikam.general: Switch to widget style:  "Fusion"
digikam.general: AlbumWatch is disabled

Same here, all sounds translated properly everywhere.

Gilles Caulier
Comment 38 caulier.gilles 2021-12-31 03:36:42 UTC
Git commit 7550b670f97c59cb26185d906164547ab5c3a8d6 by Gilles Caulier.
Committed on 31/12/2021 at 03:34.
Pushed by cgilles into branch 'master'.

Marble also provide a .qm translations to load at startup

M  +8    -1    core/app/utils/digikam_globals_bundles.cpp

https://invent.kde.org/graphics/digikam/commit/7550b670f97c59cb26185d906164547ab5c3a8d6
Comment 39 caulier.gilles 2021-12-31 09:56:15 UTC
Git commit 2fbd9f87f4eddd76e7c5385cb7807c5ee432d8a2 by Gilles Caulier.
Committed on 31/12/2021 at 09:54.
Pushed by cgilles into branch 'master'.

Windows bundle: include all Qt5 frameworks QM translation files

M  +1    -2    project/bundles/mxe/04-build-installer.sh

https://invent.kde.org/graphics/digikam/commit/2fbd9f87f4eddd76e7c5385cb7807c5ee432d8a2
Comment 40 caulier.gilles 2021-12-31 10:16:25 UTC
Git commit 0f1077f08fac0968f0e373dea5d6cb72a5ba01fa by Gilles Caulier.
Committed on 31/12/2021 at 10:14.
Pushed by cgilles into branch 'master'.

More qt trnaslations file to load at run-time, especially for qtwebengine and qtwebkit

M  +4    -3    core/app/utils/digikam_globals_bundles.cpp

https://invent.kde.org/graphics/digikam/commit/0f1077f08fac0968f0e373dea5d6cb72a5ba01fa
Comment 41 caulier.gilles 2021-12-31 14:11:11 UTC
Hi all,

One important information : under Windows, we use Qt5::QtWebKit framework, not Qt5::QtWebEngine. The reason : Windows bundle is compiled with MXE (MinGW based) and QtWebEngine do not cross-compile. Perhaps this problem will be solved later with Qt6.

So, The QtWebKit component do not contents a QM translation file in opposite of QtWebEngine. This can have a side effect of Web Service tool in digiKam, but it certainly a minor issue.

Gilles Caulier
Comment 42 caulier.gilles 2022-01-01 11:38:29 UTC
Happy new year to all in this room,

Next 7.5.0 pre-release MacOS package will be compiled with last KF5 5.89 and last KAPPS 20.12.1 frameworks with all translations files updated (PO and QM).

I plan to do it also for the Windows installer and the AppImage bundle.

Best

Gilles Caulier
Comment 43 Tyson Tan 2022-01-01 13:58:43 UTC
Happy new year and thank you for all the hard work, Gilles! :D
Comment 44 caulier.gilles 2022-01-01 16:42:01 UTC
Next 7.5.0 pre-release Windows installer will be compiled with last KF5 5.89 and last KAPPS 21.12.0 frameworks (as MAcOS PKG) with all translations files updated (PO and QM).

Gilles Caulier
Comment 45 caulier.gilles 2022-01-01 19:09:50 UTC
Next 7.5.0 pre-release AppImage Bundle will be compiled with last KF5 5.89
and last KAPPS 21.12.0 frameworks (as MacOS PKG) with all translations files
updated (PO and QM).

I close this file now.

Gilles Caulier