Bug 438619

Summary:	Finnish midsummer (juhannus) one week too early in 2021
Product:	[Frameworks and Libraries] frameworks-kholidays	Reporter:	Sami Korkalainen <sami.korkalainen>
Component:	general	Assignee:	kdepim bugs <kdepim-bugs>
Status:	RESOLVED DUPLICATE
Severity:	normal	CC:	winter
Priority:	NOR
Version:	5.83.0
Target Milestone:	---
Platform:	Arch Linux
OS:	Linux
Latest Commit:		Version Fixed In:
Sentry Crash Report:

Description Sami Korkalainen 2021-06-14 14:38:52 UTC

SUMMARY
Finnish midsummer 2021 is week too early in KHolidays. Finnish midsummer (juhannuspäivä) has been the Saturday between 20th and 26th of June since year 1955. Midsummer's eve (juhannusaatto) is naturally always the day before.

Up to 1954 juhannuspäivä was always 24th of June.

STEPS TO REPRODUCE
1. Set Digital Clock widget to show Finnish holidays.
2. View June of 2021

OBSERVED RESULT
Juhannusaatto and juhannuspäivä are 18th and 19th of June 2021. One week too early.

EXPECTED RESULT
Juhannusaatto and juhannuspäivä should be 25th and 26th of June 2021.

SOFTWARE/OS VERSIONS
Linux/KDE Plasma: Arch Linux
KDE Plasma Version: 5.22.0
KDE Frameworks Version: 5.83.0
Qt Version: 5.15.2

Comment 1 Allen Winter 2021-06-14 14:43:57 UTC

I fixed this yesterday.
Unfortunately I don't know that you'll get the fix before the holiday occurs.

*** This bug has been marked as a duplicate of bug 438542 ***

Comment 2 Sami Korkalainen 2021-06-14 14:53:12 UTC

(In reply to Allen Winter from comment #1)
> I fixed this yesterday.
> Unfortunately I don't know that you'll get the fix before the holiday occurs.
> 
> *** This bug has been marked as a duplicate of bug 438542 ***

Oh sorry, I didn't find that bug with search. Did you also fix years up to and including 1954 when juhannuspäivä (midsummer day) was always June 24th in Finland? The current practice began in 1955?