Bug 438549

Summary: Mirror tool handle is not displayed on canvas
Product: [Applications] krita Reporter: Anna Medonosova <anna.medonosova>
Component: * UnknownAssignee: Dmitry Kazakov <dimula73>
Status: RESOLVED FIXED    
Severity: normal CC: alvin, dimula73, tamtamy.tymona
Priority: NOR Keywords: regression, release_blocker
Version: nightly build (please specify the git hash!)   
Target Milestone: ---   
Platform: Appimage   
OS: Linux   
Latest Commit: Version Fixed In:
Sentry Crash Report:
Attachments: system information for bug reports
Screenshot
screenshot with handles missing

Description Anna Medonosova 2021-06-13 13:06:07 UTC
Created attachment 139285 [details]
system information for bug reports

SUMMARY
When I turn on either the horizontal or vertical mirror tool, a dashed line appears on the canvas and brush strokes are mirrored. However, the handle is missing and so the line cannot be moved.

The "Lock line" checkbox is unchecked. If you check and uncheck the checkbox, the handle does not appear.


STEPS TO REPRODUCE
1. Turn on horizontal or vertical mirror (buttons in the toolbar

OBSERVED RESULT
The handle is missing.


EXPECTED RESULT
The handle should be displayed on canvas, unless "Lock line" checkbox is checked.


ADDITIONAL INFORMATION
 Version: 5.0.0-prealpha (git 4f029a8)
Comment 1 Tiar 2021-06-15 14:22:44 UTC
That's my fault, if I remember correctly :) No idea why it happened, but happened after the local 2pp commits, probably due to algebra2d changes.
Comment 2 Dmitry Kazakov 2021-07-22 13:09:38 UTC
Hi, Anna!

Could you please check if the bug is still actual? I tested the current master and it seems like the bug is not here anymore
Comment 3 Dmitry Kazakov 2021-07-22 13:10:22 UTC
Created attachment 140256 [details]
Screenshot
Comment 4 Anna Medonosova 2021-07-23 20:00:53 UTC
(In reply to Dmitry Kazakov from comment #2)
> Hi, Anna!
> 
> Could you please check if the bug is still actual? I tested the current
> master and it seems like the bug is not here anymore

Hi, Dmitry,

I can confirm the issue is still there in git b66a85a, both locally built and in the appimage from the Binary Factory. 

I have tested turning off canvas acceleration in the settings. When acceleration is turned off, the mirror tool handles are displayed correctly. However, with acceleration on, the handles do not appear.

I have updated nvidia drivers to 460.91.03 in the meantime (I had 460.80 previously), but that didn't help.
Comment 5 Dmitry Kazakov 2021-07-28 08:48:56 UTC
Hi, Anna!

Could you please make a screenshot of the problem? I cannot understand what is wrong with the handles on your side. I've just retested on Linux and the handles are painted correctly here :(
Comment 6 Dmitry Kazakov 2021-07-29 11:25:22 UTC
Switch to waitingforinfo
Comment 7 Anna Medonosova 2021-07-30 12:48:52 UTC
(In reply to Dmitry Kazakov from comment #5)
> Hi, Anna!
> 
> Could you please make a screenshot of the problem? I cannot understand what
> is wrong with the handles on your side. I've just retested on Linux and the
> handles are painted correctly here :(

Hi!

yesterday I have retested on git efe590e (nightly appimage on linux, local build for Android). In this version, the handles were displayed correctly on both platforms. In the previous versions, the circle with the arrow was missing, only the dashed lines were present. (I will attach a screenshot.)
Comment 8 Anna Medonosova 2021-07-30 12:49:16 UTC
Created attachment 140408 [details]
screenshot with handles missing
Comment 9 Alvin Wong 2021-08-01 07:16:05 UTC
Uhhh I think I fixed this for bug 440245, I didn't realize this bug was already reported when I did that.
Comment 10 Tiar 2021-08-02 19:49:58 UTC
Thanks @Alvin!